[MGNLREST-133] Check included node-types in query responses Created: 25/Oct/17  Updated: 31/Oct/17  Resolved: 30/Oct/17

Status: Closed
Project: Magnolia REST Framework
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0

Type: Bug Priority: Neutral
Reporter: Mikaël Geljić Assignee: Sang Ngo Huu
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 3d 2.5h
Original Estimate: 2d

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: REST Queries
Sprint: Saigon 119
Story Points: 5

 Description   
  • It seems confusing that nodeTypes config may be used for checking node types of "top-level" items only, and could still include "unwanted" node-types as child-nodes
  • corollary is that if we want to include some child-nodes, then e.g. blocks may be returned in the same result set as stories, as top-level elements (despite being maybe included under stories as well). This mixture of types on root-level would be a bit more difficult to process on client side.

We first verify whether these statements are correct.

Then we should probably consider splitting nodeTypes config into primaryNodeTypes vs. secondaryNodeTypes (or maybe some other property-based flavor of config).

With this, developers would get more clarity about what to expect in responses.

See also
https://wiki.magnolia-cms.com/display/TH2/REST+TEST+Topher+Notes#RESTTESTTopherNotes-ResultsetIssues



 Comments   
Comment by Dai Ha [ 30/Oct/17 ]

verify with build: magnolia-community-demo-bundle-5.6-20171030.075022-164-tomcat-bundle.zip

Generated at Mon Feb 12 06:56:56 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.