[MGNLREST-135] Consider updating default page size Created: 26/Oct/17  Updated: 07/Nov/17  Resolved: 07/Nov/17

Status: Closed
Project: Magnolia REST Framework
Component/s: delivery
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Unassigned
Resolution: Not an issue Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: REST Queries

 Description   

[I would suggest] changing the default limit to 100 instead of 10. I think people will be confused when they dont get all the items they expected - and think the filtering is not working right.



 Comments   
Comment by Christoph Meier [ 26/Oct/17 ]

I thought it was a good idea of having a default=10.
When using queryNodes without the parameter limit, you get the default number ...
... getting 100 nodes may result in a quite big json stream (for sure depending on the node and its subnodes) ... with all its impact.
Fetching all 36 tours (with resolved tour types) returns ~152KB atm which is not massive. 100 similar tours would be ~0.5MB
-
The hardcoded 10 is anyway the "super default" for dummies which do not set their own. To prevent dummies from querying "big streams" seems clever imho.
-
But as usual just my 2 cents.

Comment by Mikaël Geljić [ 06/Nov/17 ]
  • if one gets 100 by default, wouldn't that give the impression there's no limit until starting to have more than 100 items?
  • as a rule of thumb, wouldn't it be tempting to keep the page-size "humanly processable"? it may depend on the content type—for example 100 persons is different from 100 tags;
  • depending on how complex types generally are in magnolia, I don't mind increasing the default *a bit* either
Comment by Christopher Zimmermann [ 07/Nov/17 ]

Withdrawing ticket based on valid counter-arguments.

Generated at Mon Feb 12 06:56:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.