[MGNLREST-381] Implement LinkUtil/LinkTransformer for Norsu Created: 08/May/22  Updated: 13/Feb/23  Resolved: 29/Aug/22

Status: Closed
Project: Magnolia REST Framework
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Neutral
Reporter: Oanh Thai Hoang Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File use-case.png    
Issue Links:
dependency
is depended upon by MGNLREST-380 Implement NorsuRichTextLinkResolver Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: Norsu delivery endpoint (phase 1)
Team: DeveloperX

 Description   

LinkUtil to generate a link from Node is not suitable with Norsu because it depends on JCR. We have to create a new one that suit with Sass

There are concerns about link generator like: How to handle UseURI2RepositoryMapping, I18n in Norsu

Use case: https://docs.magnolia-cms.com/product-docs/6.2/Developing/API/Delivery-API/Resolving-references-with-the-delivery-endpoint.html in rich text



 Comments   
Comment by David Lopez [ 06/Jul/22 ]

Nucleus meeting 06/07/2022

oanh.thai ,

Would you have a use case or sample of how the functionality is used? or if easier we can set a quick call together (Rabie, David and you)

Thank you in advance

Comment by Oanh Thai Hoang [ 07/Jul/22 ]

Hi dlopez

Here is sample use case: https://jira.magnolia-cms.com/browse/MGNLREST-310?focusedCommentId=263701&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-263701.

You can file step to reproduce in above ticket as well as light dev sample module.

 

Additional, The feature of creating public link has been introduce since Rest 2.2.3 and released with Magnolia 6.2.4. More details about feature in https://jira.magnolia-cms.com/browse/MGNLREST-196.

 

If you prefer a call for reproduce steps, just ping me. Thank you

 

Comment by David Lopez [ 13/Jul/22 ]

Norsu transition from Labs to Nucleus meeting 13/07/2022

Hi oanh.thai ,

UseURI2RepositoryMapping is not applicable to headless scenarios, hence to SaaS so it should be not in the scope of Technical Production Readiness.

However we have seen that the method is used in different places, e.g.: RichTextLinkResolver

I will set up a call to discuss the original need 

Next step

dlopez  to organize a call between oanh.thai , rkovarik  and apchelintcev 

Comment by David Lopez [ 21/Jul/22 ]

21/07/2022 Alignment session

Participants: oanh.thai , canh.nguyen , rkovarik , dlopez __ 

Discussion

For assets, the solution is being reworked and is intended to store only the binary in S3 and metadata such path in Norsu, so in the future we should be able to do link "norsu2norsu"

Pages is being migrated to Norsu too. Once we migrate we will not have "norsu2JCR" or "JCR2norsu" links. We will have only norsu2norsu links, so it should be doable

Decision

At this moment is difficult to resolve, since we don't know how the link will be stored for pages and assets.

Current SaaS customers are not using links in rich text editor

Shall we disable/remove those buttons from rich text editor

  • It can be done by Nucleus in UI
    • Ticket NORSU-429 created

 

We can leave the work for after TPR since we have a lot of dependencies at this moment and most likely will need re-work if we try to tackle in advance

Generated at Mon Feb 12 06:59:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.