[MGNLREST-558] Re enable disabled integration tests on master branch Created: 08/Nov/22 Updated: 10/Jan/24 Resolved: 09/Nov/23 |
|
| Status: | Closed |
| Project: | Magnolia REST Framework |
| Component/s: | None |
| Affects Version/s: | 3.0.0, 3.0.1 |
| Fix Version/s: | 3.0.0 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Javier Benito | Assignee: | Quach Hao Thien |
| Resolution: | Done | Votes: | 0 |
| Labels: | VN-Testing, dx-core-6.3 | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | 5d 1.5h | Time Spent: | 5d 1.5h |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Issue Links: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: | ||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Epic Link: | 6.3 Consolidation | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Work Started: | ||||||||||||||||||||||||||
| Approved: |
Yes
|
|||||||||||||||||||||||||
| Comments |
| Comment by Javier Benito [ 29/Nov/22 ] |
|
Regarding this failing test on master: 2022-11-07 14:40:05,716 ERROR magnolia.rest.reference.dam.AssetReferenceResolver: Cannot find provider for asset jcr:d01deefa-dba9-4708-8cfa-604320720253 This is caused because there is no AssetProvider implemented, using Magnolia 6.3, and Rest module 3.0, that is used within rest integration tests, so this call raises an error and no asset is found, nor returned, so tests fail (assetProviderRegistry providers are empty). So probably we need to use dam s3 assets on test webapp during these tests, but trying to add it, an error is raised because of lack of configuration: 1) [Guice/ErrorInUserInjector]: Error injecting SaasDamConfiguration using MicroProfileConfigSupportModule$ConfigPropertyInjector@7371ca07. Reason: PropertyResolverException: Error while trying to resolve config property with the key: info.magnolia.config.rest.s3.region. The key is missing and there is no defaultValue present in the @ConfigProperty annotation. at FastlyLinkProvider.<init>(FastlyLinkProvider.java:42) \_ for 1st parameter at GuiceComponentConfigurationModule.bindImplementation(GuiceComponentConfigurationModule.java:162) \_ installed by: Modules$OverrideModule -> Modules$OverrideModule -> GuiceComponentProviderBuilder$1 -> GuiceComponentConfigurationModule at FastlyPurgeAssetService.<init>(FastlyPurgeAssetService.java:46) \_ for 1st parameter at GuiceComponentConfigurationModule.bindImplementation(GuiceComponentConfigurationModule.java:162) \_ installed by: Modules$OverrideModule -> Modules$OverrideModule -> GuiceComponentProviderBuilder$1 -> GuiceComponentConfigurationModule while locating FastlyPurgeAssetService |