[MGNLREST-6] As a customer I can expose commands as web services Created: 07/May/13  Updated: 22/Nov/13  Resolved: 25/Oct/13

Status: Closed
Project: Magnolia REST Framework
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0

Type: Story Priority: Neutral
Reporter: Magnolia International Assignee: Philip Mundt
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Date of First Response:
Epic Link: REST support
Sprint: 5.2-rc1

 Comments   
Comment by Philip Mundt [ 17/Oct/13 ]

Sample test calls:

Page activation

curl -H "Content-Type: application/json" -X POST --data "{\"path\":\"/demo-project\",\"repository\":\"website\",\"recursive\":false,\"uuid\":\"1be12547-ad82-4c83-8396-213466ceb003\"}" -v --user superuser:superuser http://localhost:8080/.rest/commands/website/activate

Mark page as deleted

curl -H "Content-Type: application/json" -X POST --data "{\"path\":\"/demo-project\",\"deleteNode\":\"about\",\"repository\":\"website\",\"recursive\":false,\"uuid\":\"1be12547-ad82-4c83-8396-213466ceb003\"}" -v --user superuser:superuser http://localhost:8080/.rest/commands/markAsDeleted

(CommandEndpoint has to be "enabled" in role "rest" first - by default it is disabled)

Comment by Tobias Mattsson [ 24/Oct/13 ]

The classes in package info.magnolia.rest.command should be in the services module, not in the rest-integration module.

There should be one bootstrap file for each endpoint.

CommandEndpointDefinition is missing a license header.

There's no need to specify public on interfaces.

ConfiguredCommandEndpointDefinition javadoc says descriptors when it should be definition.

Comment by Philip Mundt [ 25/Oct/13 ]
  • Move classes in package info.magnolia.rest.command to services module
  • Separate bootstrap file for each endpoint
  • Add license header to CommandEndpointDefinition
  • Remove public from interfaces
  • Fix javadoc of ConfiguredCommandEndpointDefinition
Generated at Mon Feb 12 06:55:39 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.