[MGNLREST-681] AssetReferenceResolver#resolve catches different exception than it's actually thrown in JcrAssetProvider#getNodeByIdentifier Created: 25/Apr/23  Updated: 06/Jun/23  Resolved: 06/Jun/23

Status: Closed
Project: Magnolia REST Framework
Component/s: delivery
Affects Version/s: 2.2.15
Fix Version/s: 3.0.0, 2.2.19

Type: Bug Priority: Neutral
Reporter: Marzena Sieradzka Assignee: Valeria Robles-Garzon
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 0.75d Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLREST-712 Review Sub-task Closed Oanh Thai Hoang  
MGNLREST-713 Implement Sub-task Completed Valeria Robles-Garzon  
MGNLREST-714 PiQA Sub-task Closed Oanh Thai Hoang  
MGNLREST-715 QA Sub-task Closed Oanh Thai Hoang  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Epic Link: DevX Bucket
Sprint: DevX 38, DevX 39
Story Points: 3
Team: DeveloperX
Work Started:
Approved:
Yes

 Description   

info.magnolia.rest.reference.dam.AssetReferenceResolver has this code:

} catch (IllegalArgumentException e) {
    log.error("Key {} is not valid Asset key", item);
}

but info.magnolia.dam.jcr.JcrAssetProvider from DAM Module has this code:

} catch (RepositoryException e) {
    throw new IllegalItemKeyException(itemKey, this, e.getMessage());
}

so exceptions thrown for invalid identifier are actually never caught. Which results of HTTP 500 response.


Generated at Mon Feb 12 07:02:10 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.