[MGNLREST-689] SaaS Delivery endpoint referenceDepth should have default of 1 Created: 09/May/23  Updated: 18/May/23  Resolved: 18/May/23

Status: Closed
Project: Magnolia REST Framework
Component/s: None
Affects Version/s: 3.0.0
Fix Version/s: 3.0.0

Type: Bug Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Canh Nguyen
Resolution: Fixed Votes: 0
Labels: MagnoliaX
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLREST-690 Implementation Sub-task Completed Canh Nguyen  
MGNLREST-691 Review Sub-task Completed Marek Strucka  
MGNLREST-692 Pre-Integration QA Sub-task Completed Chuong Doan Huy  
MGNLREST-693 QA Sub-task Completed Chuong Doan Huy  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Date of First Response:
Epic Link: SaaS Post-TPR - DevX
Sprint: DevX 37, DevX 38
Team: DeveloperX
Work Started:
Approved:
Yes

 Description   

Same as https://magnolia-cms.atlassian.net/browse/MX-70

 

On Norsu - when you do not supply a referenceDepth property on a delivery endpoint, then no references are resolved at all.

Expected behaviour is that the default value for referenceDepth is 1 (as documented) and that if you do not supply the property that reference resolving acts on the top level. (As it behaves in JCR)

Same problem happens with assetReferenceResolver and norsuReferenceResolver

Example configuration:

 

$type: pagesDeliveryEndpoint_v2
# referenceDepth: 2 

references:
  - name: imageReference
    propertyName: image
    referenceResolver:
      $type: assetReferenceResolver

  - name: activityReference
    propertyName: targetActivity
    referenceResolver:
      $type: norsuReferenceResolver
      targetWorkspace: activities
      expand: true 


 Comments   
Comment by Christopher Zimmermann [ 10/May/23 ]

Hi canh.nguyen is version 3 correct here? Just checking! The fix should be included on current SaaS instances.

Comment by Canh Nguyen [ 16/May/23 ]

Hi czimmermann , the version is correct. We use version 3 since we added Norsu to REST repo. And current SaaS uses newest REST 3.0.0 snapshot.

Generated at Mon Feb 12 07:02:14 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.