AssetReferenceResolver#resolve catches different exception than it's actually thrown in JcrAssetProvider#getNodeByIdentifier
(MGNLREST-681)
|
|
| Status: | Closed |
| Project: | Magnolia REST Framework |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Sub-task | Priority: | Neutral |
| Reporter: | Valeria Robles-Garzon | Assignee: | Oanh Thai Hoang |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 0.75d | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Date of First Response: | |
| Sprint: | DevX 38, DevX 39 |
| Team: |
| Comments |
| Comment by Oanh Thai Hoang [ 02/Jun/23 ] |
|
This is QA output: I don't see 500 anymore. But for AssetProvider.IllegalItemKeyException ->
2023-06-02 13:40:08,070 ERROR magnolia.rest.reference.dam.AssetReferenceResolver: ItemKey <info.magnolia.dam.api.ItemKey@3462253e> can not be handled by info.magnolia.dam.jcr.JcrAssetProvider@16a93684 : invalid identifier: d01deefa-dba9-4708-8cfa-60432072025-13
for NoSuchAssetProviderException ->
2023-06-02 15:07:30,322 ERROR magnolia.rest.reference.dam.AssetReferenceResolver: No AssetProvider with id <jcr>
for AssetProvider.AssetNotFoundException -> 2023-06-02 15:26:04,658 ERROR magnolia.rest.reference.dam.AssetReferenceResolver: No Asset found for ItemKey <info.magnolia.dam.api.ItemKey@435cb0dd>
Only IllegalItemKeyException, I can see it show identifier, uuid. The others, I can not see asset uuid that cause exception. I think we can improve a log to log asset id as well in another ticket |
| Comment by Oanh Thai Hoang [ 06/Jun/23 ] |
|
QA is done. Here is output of error log
ERROR info.magnolia.rest.reference.dam.AssetReferenceResolver 06.06.2023 01:42:41 -- Resolving asset jcr1:52469758-3875-4ac1-b2bb-8deac5c8419b has error: No AssetProvider with id <jcr1> ERROR info.magnolia.rest.reference.dam.AssetReferenceResolver 06.06.2023 01:57:32 -- Resolving asset jcr:52469758-3875-4ac1-b2bb-8deac5c8419b-1 has error: ItemKey <info.magnolia.dam.api.ItemKey@918eb4e8> can not be handled by info.magnolia.dam.jcr.JcrAssetProvider@35265717 : invalid identifier: 52469758-3875-4ac1-b2bb-8deac5c8419b-1 ERROR info.magnolia.rest.reference.dam.AssetReferenceResolver 06.06.2023 01:59:34 -- Resolving asset jcr:52469758-3875-4ac1-b2bb-8deac5c8419b has error: No Asset found for ItemKey <info.magnolia.dam.api.ItemKey@64c62a84> |