[MGNLREST-756] Extend default health check for database connection Created: 02/Oct/23  Updated: 09/Oct/23  Resolved: 06/Oct/23

Status: Closed
Project: Magnolia REST Framework
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Christoph Damm Assignee: Unassigned
Resolution: Not an issue Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

The current status/healthcheck endpoints only checks for 
MgnlContext.hasInstance() && !this.moduleManager.getStatus().needsUpdateOrInstall() ? Response.ok("{}").build() : Response.status(Status.SERVICE_UNAVAILABLE).build();
 
However my assumption is that checking for the context itself does not include a check whether the JCR/Database is reachable at all, e.g. by doing a query against the configuration workspace (which should always be there).
 
Of course we can add this via a custom java endpoint ourself and override the above implementation, but wouldn't it be good to add it as default?

The extended HC module could also be used, however for DX only.



 Comments   
Comment by Jonathan Ayala [ 06/Oct/23 ]

Hi Christoph,

Your request is quite interesting but this is not the right channel to ask for it. Please do not hesitate in submit your ideas by the appropriate means and our team will consider their implementation. As you mentioned, we already have the extended health check module for DX. If you are considering getting a license please follow these steps.

Regards,
Jonathan.

Comment by Christoph Damm [ 09/Oct/23 ]

Thank you for your feedback Jonathan, some of our clients have a dx some don't.

For now i decided to decorate the default implementation and add it myself, nevertheless i added my suggestion to the roadmap (thanks for pointing the process out to me.

Regards,

Christoph

Generated at Mon Feb 12 07:02:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.