[MGNLREST-760] AdditionNodeWrapper should override getProperty method Created: 09/Oct/23 Updated: 13/Dec/23 Resolved: 29/Nov/23 |
|
| Status: | Closed |
| Project: | Magnolia REST Framework |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.0.0, 2.2.24 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Carlos Cantalapiedra | Assignee: | Canh Nguyen |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Σ Remaining Estimate: | 0d | Remaining Estimate: | 0d |
| Σ Time Spent: | 3d | Time Spent: | 3d |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Attachments: |
|
|||||||||||||||||||||||||
| Issue Links: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: |
|
|||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
|
|||||||||||||||||||||||||
| Epic Link: | Support | |||||||||||||||||||||||||
| Sprint: | DevX 51 | |||||||||||||||||||||||||
| Story Points: | 3 | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Work Started: | ||||||||||||||||||||||||||
| Approved: |
Yes
|
|||||||||||||||||||||||||
| Description |
DescriptionThe AdditionNodeWrapper overrides the getProperties method, which allows the user to iterate over the additionalProperties of the node. But the getProperty method is not overwritten, so when for a property which is stored at additionalProperties (e.g, when we create a link from a page to another page, there is a @link property stored within the referenced page) it can only be accessed through the getProperties method because the getProperty (super class) doesn't look within the additionalProperties attribute. Steps to reproduce
Expected resultsThe getProperty method should return true when the attribute @link is checked Development notesOverride the getProperty method so it also checks within the additionalAttributes list |