[MGNLRESTCL-122] Review deprecated methods before release 6.2 Created: 18/Dec/19  Updated: 19/Feb/20  Resolved: 17/Jan/20

Status: Closed
Project: REST Client
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0

Type: Task Priority: Neutral
Reporter: Jorge Franco Assignee: Quach Hao Thien
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 2d 5.95h
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: Declarative REST clients
Sprint: Declarative REST 14
Story Points: 3

 Description   

With the release of 2.0, some methods are deprecated, some of them without implementation, for example https://git.magnolia-cms.com/projects/MODULES/repos/rest-client/browse/magnolia-rest-client/src/main/java/info/magnolia/rest/client/registry/RestClientRegistry.java#109

 

Make a list of all deprecated methods, and then make sure all have a correct implementation, don't leave deprecated methods without implementation.



 Comments   
Comment by Roman Kovařík [ 20/Dec/19 ]

So I’ve check an old connector and all works fine except getRestClient method, so supporting the old clients might be a one liner.
As a side note, even after updating of dependencies the project didn’t fail at compile time, but was throwing UOO at runtime which was not a good developer experience and we could generally avoid this in the future.

Comment by Quach Hao Thien [ 13/Jan/20 ]

All Rest-Client deprecated classes and methods are collected in this sheet: https://docs.google.com/spreadsheets/d/1RZ9vhXcLvVuiAMiQ52FZaSm6iU6Gy4PaEbIdiHP_MK4/edit#gid=0

Comment by Quach Hao Thien [ 14/Jan/20 ]

Empty Implementation Deprecated Methods

  1. info.magnolia.rest.client.call.AbstractRestCall#doCall
  2. info.magnolia.rest.client.DefaultRestClient#handleRestException
  3. info.magnolia.rest.client.DefaultRestClient#setRestClientDefinition
  4. info.magnolia.rest.client.registry.RestClientRegistry#getRestClient
  5. info.magnolia.rest.client.registry.RestClientRegistry#unregisterAndRegister(java.util.Set<java.lang.String>, java.util.List<info.magnolia.rest.client.registry.RestClientProvider>)
  6. info.magnolia.resteasy.client.SSLRestEasyClientDefinition#setKeyStorePath
  7. info.magnolia.resteasy.client.SSLRestEasyClientDefinition#setKeyStorePassword
  8. info.magnolia.resteasy.client.SSLRestEasyClientDefinition#setKeyStoreType
  9. info.magnolia.resteasy.client.SSLRestEasyClientDefinition#setHttpPort
  10. info.magnolia.resteasy.client.SSLRestEasyClientDefinition#setHttpsPort
Comment by Jorge Franco [ 14/Jan/20 ]

Like the number of empty implementations is higher than expected, in this ticket we will create the implementation of getRestClient. I have created https://jira.magnolia-cms.com/browse/MGNLRESTCL-128 to check usage in all modules.

Generated at Mon Feb 12 10:43:26 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.