[MGNLRESTCL-179] Test failures after bumping to Java 11 Created: 22/Jun/22  Updated: 21/Feb/23  Resolved: 23/Jan/23

Status: Closed
Project: REST Client
Component/s: None
Affects Version/s: 3.0.0
Fix Version/s: 3.0.0

Type: Bug Priority: Neutral
Reporter: Michael Duerig Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
is caused by MAGNOLIA-8044 Invert dependency between Registry an... Closed
Relates
relates to MGNLRESTCL-178 Build on JDK 11 (rest-client) Closed
relation
is related to MGNLREST-434 Change rest endpoint in Resource app ... Selected
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Epic Link: 6.3 Consolidation
Team: Foundation

 Description   

Since bumping to Java 11 the following tests fail:

info.magnolia.rest.client.integration.RestClientDisabledIntegrationTest#invokeWhenClientIsDisabled
info.magnolia.rest.client.integration.RestClientDisabledIntegrationTest#disabledClientsAreNotRegistered
info.magnolia.rest.client.integration.RestClientOpenApiIntegrationTest#restCallsArePresent
info.magnolia.rest.client.integration.RestClientOpenApiIntegrationTest#validateRestDefinition
info.magnolia.rest.client.integration.RestClientOpenApiIntegrationTest#validateRestCallDefinition
info.magnolia.rest.client.integration.RestClientOpenApiIntegrationTest#getPetById
info.magnolia.rest.client.integration.RestClientOpenApiIntegrationTest#addNewPet
info.magnolia.rest.client.integration.RestClientOpenApiMissingOperationIdIntegrationTest#restCallsArePresent
info.magnolia.rest.client.integration.RestClientOpenApiMissingOperationIdIntegrationTest#validateRestDefinition 

Looks like the changes from MAGNOLIA-8044 broke RestClientRegistry with the register and and onRegister callbacks not being called anymore.

See also MGNLRESTCL-178.

 



 Comments   
Comment by Michael Duerig [ 23/Jan/23 ]

Fixed at https://git.magnolia-cms.com/projects/MODULES/repos/rest-client/commits/16e4e8b79f077aeae4e76043d71e59fd56d20127#magnolia-rest-client/src/main/java/info/magnolia/rest/client/registry/RestClientRegistry.java

Generated at Mon Feb 12 10:43:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.