[MGNLRESTUI-20] Use Location parameter for path parameters Created: 25/Feb/20  Updated: 02/Mar/20

Status: Open
Project: Magnolia REST Client UI
Component/s: None
Affects Version/s: 1.0
Fix Version/s: None

Type: Improvement Priority: Medium
Reporter: Scot Rhodes Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

The info.magnolia.graalvm.rest.ui.JsonAppDatasourceDefinition does not have a way to account for path parameters, i.e. 
path: '{index}/_mapping'
I propose adding a property in an ordered list to take in the location parameter and apply them to the corresponding path parameter.

Example:

locationParameterMappings:

  - index

Corresponds to Location: 'app:elasticsearch:browser;stories::'

where the path parameter /{index}/_mapping translates to /stories/_mapping. I have forked the rest-client-ui project and will create a branch with this ticket number with my proposed changes.

https://git.magnolia-cms.com/users/srhodes/repos/rest-client-ui/browse



 Comments   
Comment by Christopher Zimmermann [ 02/Mar/20 ]

Im confused by the 'graalvm' in 'info.magnolia.graalvm.rest.ui.JsonAppDatasourceDefinition' did you mean something else?

Comment by Christopher Zimmermann [ 02/Mar/20 ]

It's hard for me to understand the description without more context. Could you provide more details about the example - maybe with some bigger yaml fragments from app definition?

Generated at Mon Feb 12 06:51:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.