[MGNLRESTUI-25] Consolidate type aliases Created: 07/Apr/20 Updated: 20/May/20 Resolved: 23/Apr/20 |
|
| Status: | Closed |
| Project: | Magnolia REST Client UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0.1 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Jorge Franco | Assignee: | Quach Hao Thien |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 5.5h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Release notes required: |
Yes
|
||||||||
| Documentation update required: |
Yes
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | Declarative REST clients | ||||||||
| Sprint: | 6.2.1 Ramp-up 22 | ||||||||
| Story Points: | 1 | ||||||||
| Description |
|
At the moment we have this type aliases, would be nice use the same prefix 'json' for all of them: restLinkField Also as reminder, update documentation, see |
| Comments |
| Comment by Quach Hao Thien [ 14/Apr/20 ] |
|
Hi czimmermann, I didn't notice the thread on declarative rest channel regarding to this ticket, and you said you prefer "rest" instead of "json" (https://magnolia-cms.slack.com/archives/CL3GYQBB2/p1586274248007000?thread_ts=1586271798.005300&cid=CL3GYQBB2 . In grooming session, rest-client team discussed and agreed to use "json" as prefix, since it relevant to the datatype of the field as Json, do you have any objection? |
| Comment by Christopher Zimmermann [ 20/Apr/20 ] |
|
Hi - no objection, Thien. Sorry for late response was on holidays. |
| Comment by Quach Hao Thien [ 23/Apr/20 ] |
|
For QA: restComboBoxField has been deprecated and used as compatible alias -> use jsonComboBoxField instead restLinkField has been deprecated and used as compatible alias -> use jsonLinkField instead |