Make RSS Aggregator module compatible with Magnolia 5. (MGNLRSSAGG-101)

[MGNLRSSAGG-111] Update RSSAggregator module installation, erase obsolete classes and bootstrap files. Created: 16/Oct/13  Updated: 18/Nov/13  Resolved: 15/Nov/13

Status: Closed
Project: Magnolia RSS Aggregator Module
Component/s: None
Affects Version/s: 2.2
Fix Version/s: 2.2

Type: Sub-task Priority: Neutral
Reporter: Aleksandr Pchelintcev Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
duplicate
is duplicated by MGNLRSSAGG-122 Add update task to remove old configu... Closed
relation
is related to MGNLADMLEG-37 clean up configuration on migration f... Closed
Template:
Date of First Response:
Sprint: 5.2-rc2

 Comments   
Comment by Federico Grilli [ 28/Oct/13 ]

I think update tasks can be simplified, i.e.

.addTask(new NodeExistsDelegateTask("Set property", "Set workspace for rss importer", RepositoryConstants.CONFIG, "/modules/data/config/importers/rssaggregator",
                       new PropertyExistsDelegateTask("", "", RepositoryConstants.CONFIG, "/modules/data/config/importers/rssaggregator", "repository",
                               new SetPropertyTask("", RepositoryConstants.CONFIG, "/modules/data/config/importers/rssaggregator", "repository", RSSAggregatorConstants.WORKSPACE), null)

one could omit the check for parent node existence which already done by PropertyExistsDelegateTask

.addTask(new PropertyExistsDelegateTask("Do something", "Does something.", RepositoryConstants.CONFIG, "/modules/data/config/importers/rssaggregator", "repository", 
new SetPropertyTask("", RepositoryConstants.CONFIG, "/modules/data/config/importers/rssaggregator", "repository", RSSAggregatorConstants.WORKSPACE))
Comment by Roman Kovařík [ 08/Nov/13 ]
  • Migration to new app is registered under wrong version:
            register(DeltaBuilder.update("2.1", "")
    
  • Typo:
    .addTask(new RemoveNodeTask("Remove rss aggregator trees", "Remove RSSAggregator tree from data module", "config", "/modules/data/tree/RssAggregator"))
  • Update from Magnolia 5:
    • /modules/data/types/RssAggregator is not removed on update.
    • /modules/adminInterface/pages/rssaggregator should be removed from this module instead of admininterface-legacy (MGNLADMLEG-37)
    • adminInterface/config/menu/rssaggregator is not removed on update.
  • Update from Magnolia 4.5.x:
    • /modules/adminInterface/pages/rssggregator is not removed on update.
    • /modules/adminInterface/config/menu/config/rssggregator is not removed on update.
  • missing VersionHandlerTest
  • pls re-resolve parent task when done
Generated at Mon Feb 12 07:05:39 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.