[MGNLRSSAGG-14] Feed Generator fails to produce empty feed Created: 07/Apr/09 Updated: 22/Jun/09 Resolved: 22/Jun/09 |
|
| Status: | Closed |
| Project: | Magnolia RSS Aggregator Module |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0.1 |
| Type: | Bug | Priority: | Major |
| Reporter: | Jan Haderka | Assignee: | Jan Haderka |
| Resolution: | Obsolete | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: |
| Description |
|
When feed data are not fetched yet, paragraph displays meaningful message, however combind feed generator fails with exception rather then producing empty feed. Exception:
"javax.servlet.ServletException: Failed to process request
info.magnolia.module.rssaggregator.servlet.AbstractServlet.processRequest(AbstractServlet.java:89)
info.magnolia.module.rssaggregator.servlet.AbstractServlet.doGet(AbstractServlet.java:58)
..............."
Root Cause:
"info.magnolia.module.rssaggregator.generator.FeedGenerationException: Failed to generate Feed using generator
'info.magnolia.module.rssaggregator.generator.RSSModuleFeedGenerator'
info.magnolia.module.rssaggregator.generator.AbstractSyndFeedGenerator.generate(AbstractSyndFeedGenerator.java:82)
info.magnolia.module.rssaggregator.servlet.FeedSyndicationServlet.handleRequest(FeedSyndicationServlet.java:70)
................."
|
| Comments |
| Comment by Rob van der Linden Vooren [ 06/May/09 ] |
|
So what would be the expected behaviour?
Also (not per se related to this issue but made me think of it):
|
| Comment by Jan Haderka [ 06/May/09 ] |
From the client point definitively write an empty feed. If I'm a reader and find there are no items in the feed, it is fine, next time i recheck this feed there will be some data so i know those are new. Happy path, no exceptional flow. If there is an error stack trace instead of empty feed, or no response at all, we depend on the behaviour of the reader and how it will deal with it (ignore, disable fetching of corrupted feed, ... whatever). So I think definitively empty feed.
I believe, in both of those cases stacktrace is fine since those are not errors that can recover on their own and whoever is checking log files should find it and fix it (or notify user to fix it). |
| Comment by Jan Haderka [ 22/Jun/09 ] |
|
This is not the case any more. Empty feed is produced as expected. Just tested on 4.1. |