[MGNLRSSAGG-150] Link to a feed is stored as a path but requested as an identifier in the code Created: 04/Feb/14  Updated: 07/Mar/14  Resolved: 06/Mar/14

Status: Closed
Project: Magnolia RSS Aggregator Module
Component/s: None
Affects Version/s: 2.2.1
Fix Version/s: 2.2.3

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Aleksandr Pchelintcev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Dialogs store the link to a feed as a path, not an uiid (no converted defined). However the methode AbstractFeedModel:getFeedTitle access this attribute as a UIID:

 public String getFeedTitle(String feedLink) {
        try {
            if (content.hasProperty("feed")) {
                Node rssParent = SessionUtil.getNodeByIdentifier(RSSAggregatorConstants.WORKSPACE, content.getProperty("feed").getString());
                return getFeedProperty(rssParent, FEEDS_NODE, "link", feedLink, "title");
            }
        } catch (RepositoryException e) {
            log.error("Problem while fetching feed title for statistics: " + e.getMessage());
        }
        return null;
    }

The method SessionUtil.getNode should be used instead.



 Comments   
Comment by Aleksandr Pchelintcev [ 06/Mar/14 ]

The main fix for the issue is located in bac268bf38146b8e9ad76a35f3aa5f6784f28d2d (wrongly pushed under MGNLRSSAGG-149, will fix that with interactive rebase when merging with master later).

Comment by Roman Kovařík [ 06/Mar/14 ]

Commit: https://git.magnolia-cms.com/gitweb/?p=modules/rssaggregator.git;a=commitdiff;h=bac268bf38146b8e9ad76a35f3aa5f6784f28d2d

Generated at Mon Feb 12 07:06:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.