[MGNLRSSAGG-153] updateConfiguration performance issue Created: 19/Feb/14  Updated: 13/Mar/14  Resolved: 02/Mar/14

Status: Closed
Project: Magnolia RSS Aggregator Module
Component/s: None
Affects Version/s: 2.0
Fix Version/s: 2.2.3

Type: Task Priority: Critical
Reporter: Magnolia International Assignee: Aleksandr Pchelintcev
Resolution: Fixed Votes: 0
Labels: maintenance, quickwin, support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: XML File rss.MagnoliaBlogs(11).xml    
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Release notes required:
Yes
Date of First Response:

 Description   

updateConfiguration is using PlanetFeedSearcher which is a visitor looking for a node with the property planetFeed set to false. Using a query should solve the problem.

How to reproduce:
1. Create several Aggregators or import the rss.MagnoliaBlogs(11).xml several times
2. Open the Configuration tab in the RSS Aggregator apps
=> The screen takes a few seconds/minutes to be loaded



 Comments   
Comment by Roman Kovařík [ 24/Feb/14 ]

Reopened:

  1. "SELECT * FROM [%S] WHERE planetFeed = true" ...probably by mistake - uppercase S
  2. Add unit test:
     @Test
        public void test() throws Exception {
            // GIVEN
            RSSAggregatorConfigurationView view = mock(RSSAggregatorConfigurationView.class);
            RSSAggregatorConfigurationPresenter presenter = new RSSAggregatorConfigurationPresenter(view, null, null);
            MgnlContext.getJCRSession(RSSAggregatorConstants.WORKSPACE).getRootNode().addNode("test", rssAggregatorNodeType).setProperty("planetFeed", true);
    
            // WHEN
            presenter.updateConfiguration();
    
            // THEN
            verify(view).setPlanetConfigVisible(true);
        }
    
Comment by Roman Kovařík [ 03/Mar/14 ]

Reviewed, please squash to one commit before integrating.

Generated at Mon Feb 12 07:06:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.