[MGNLRSSAGG-173] Scheduled import job fails on update of last modified date Created: 20/May/14  Updated: 06/Jun/14  Resolved: 05/Jun/14

Status: Closed
Project: Magnolia RSS Aggregator Module
Component/s: None
Affects Version/s: 2.3
Fix Version/s: 2.3

Type: Bug Priority: Neutral
Reporter: Ondrej Chytil Assignee: Ondrej Chytil
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File failed_debug.txt     Text File stacktrace.txt     Text File successful_debug.txt    
Issue Links:
relation
is related to MAGNOLIA-5776 MgnlPropertySetting wrapper fails aft... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Steps to reproduce:

  • use the latest snapshot
  • add new feed with schedule (more frequent works better, issue is not happening every time)
  • you get errors (see the stacktrace) when the job is launched
  • despite that job is executed successfully and data are imported


 Comments   
Comment by Ondrej Chytil [ 23/May/14 ]

Added stacktraces with debug level at MgnlPropertySetting* classes for both successful and failed job.

Comment by Jan Haderka [ 04/Jun/14 ]
protected Node getOrCreateNode(Node contentNode, String name, String itemType) throws RepositoryException {}

looks like exact copy of same method from NodeUtil. Can't you just use that one.
On similar note, I would pbly deprecate RssModule.getInstance() method ... there should be no need for it.

And one more question: why are we releasing separate version for 5.2 and 5.3 versions of Magnolia? What is the difference in code between those two?

Comment by Ondrej Chytil [ 04/Jun/14 ]

looks like exact copy of same method from NodeUtil. Can't you just use that one.

Which one? Sorry if I'm blind but I cannot really see the same method. Anyway using the createPath from NodeUtil led to exceptions. Even without saving the session option. Don't know why.

On similar note, I would pbly deprecate RssModule.getInstance() method ... there should be no need for it.

OK, although now it has proper code so by my opinion it can stay. It's easier to call directly this kind of method if it's available than writing IOC call.

And one more question: why are we releasing separate version for 5.2 and 5.3 versions of Magnolia? What is the difference in code between those two?

No clue. Just noticed one day there is 2.4 version for M 5.3 so had to keep the changes in both.

Comment by Jan Haderka [ 04/Jun/14 ]

Which one? Sorry if I'm blind but I cannot really see the same method. Anyway using the createPath from NodeUtil led to exceptions. Even without saving the session option. Don't know why.

Yeah, that one. If it fails. Find out why. Is it a bug in the code? Ignoring the problem is not same as solving the problem.

Comment by Ondrej Chytil [ 04/Jun/14 ]

Yeah, that one. If it fails. Find out why. Is it a bug in the code? Ignoring the problem is not same as solving the problem.

I did. I used only the necessary code for my issue. AFAIK there is no issue with method, just in this particular case. So since the method has unnecessary logic I replaced it with simpler solution (in that case node is added just to parent node, there is no need to call method which creates the whole path).

Comment by Jan Haderka [ 05/Jun/14 ]

AFAIK there is no issue with method, just in this particular case.

What is the issue in this case. Checking the code of your method against the code path executed in NodeUTil.createPath() the only difference is addition of the mixin otherwise it's same. What problem is this extra mixin causing?

Comment by Ondrej Chytil [ 05/Jun/14 ]

In the end I was not able to reproduce the issue using NodeUtil.createPath method so that one was used instead of getOrCreateNode.

Generated at Mon Feb 12 07:06:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.