[MGNLRSSAGG-195] ConcurrentModificationException exception after setting "Use different settings for this feed" Created: 24/Feb/15 Updated: 01/Jul/15 Resolved: 04/Mar/15 |
|
| Status: | Closed |
| Project: | Magnolia RSS Aggregator Module |
| Component/s: | None |
| Affects Version/s: | 2.3.3 |
| Fix Version/s: | 2.3.4 |
| Type: | Bug | Priority: | Blocker |
| Reporter: | Evzen Fochr | Assignee: | Evzen Fochr |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
Error java.util.ConcurrentModificationException possibly caused by two jobs(but same feed) concurently try to execute at same time. It start after i set "Use different settings for this feed". |
| Comments |
| Comment by Jan Haderka [ 27/Feb/15 ] |
|
| Comment by Jan Haderka [ 27/Feb/15 ] |
|
| Comment by Jan Haderka [ 04/Mar/15 ] |
But in general, yeah, it's moving in the right direction |
| Comment by Evzen Fochr [ 04/Mar/15 ] |
|
sql to sql2 - done |
| Comment by Jan Haderka [ 05/Mar/15 ] |
jobs.put(job.getName(), job); addJobToScheduler(job); but the add method has some condition inside which might result in job not really being added to scheduler ... is it still correct to add it to the list of jobs?
/**
* @deprecated since 2.3.4, use {@link #RSSAggregator(SchedulerModule scheduler)} instead.
*/
@Deprecated
public RSSAggregator() {
}
good job depracting that ctor, but you still need to initialize scheduler inside it otherwise someone using it would end up with NPE. Just because it's deprecated doesn't mean it should not be functional. |
| Comment by Evzen Fochr [ 05/Mar/15 ] |
|
jobs.put(job.getName(), job); is needed because job is called by actions "Import feed now" and "Import all feeds now" even if job is not scheduled for automatic import. |