[MGNLRSSAGG-211] Old properties are still present in bootstrap files Created: 07/Dec/16  Updated: 19/Dec/16  Resolved: 19/Dec/16

Status: Closed
Project: Magnolia RSS Aggregator Module
Component/s: None
Affects Version/s: None
Fix Version/s: 2.5.1

Type: Bug Priority: Neutral
Reporter: Maxime Michel Assignee: Philip Mundt
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLUI-1577 Make idKeyTranslator configurable in ... Closed
is related to MGNLDAM-184 Replace our asset chooser with the st... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Visible to:
Maxime Michel
Epic Link: Definitions app problems
Sprint: Basel 75
Story Points: 1

 Description   

Leading to the following Definitions app problems:

Apps

app: rssAggregator
from jcr
at /modules/rssaggregator/apps/rssAggregator
Source data processing problem: Property [workspace] not found in class [info.magnolia.dam.app.assets.field.translator.AssetCompositeIdKeyTranslator], property is not assigned: /subApps/detail/editor/form/tabs/mainTab/fields/feeds/field/fields/img/identifierToPathConverter

Property needs to be renamed to workspaceName (see interface info.magnolia.ui.form.field.converter.IdentifierToPathConverter#setWorkspaceName in UI. This property is currently ignored, but will be updated anyways (for the sake of n2b's happiness) (see MGNLUI-4101).

/modules/rssaggregator/apps/rssAggregator/subApps/detail/editor/form/tabs/mainTab/fields/feeds/field/fields/img/identifierToPathConverter@workspace

Dialogs

The name property for ConfiguredFormDialogDefinition was last seen in 2012: https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/magnolia-ui-dialog/src/main/java/info/magnolia/ui/dialog/definition/ConfiguredFormDialogDefinition.java?until=f28386fe3d31eb106a53d89baeddd790519a5660&untilPath=magnolia-ui-model%2Fsrc%2Fmain%2Fjava%2Finfo%2Fmagnolia%2Fui%2Fmodel%2Fdialog%2Fdefinition%2FConfiguredDialogDefinition.java

However, it is still around in many bootstraped nodes:

dialog: rssaggregator:combinedFeed
from jcr
at /modules/rssaggregator/dialogs/combinedFeed
Source data processing problem: Property [name] not found in class [info.magnolia.ui.dialog.definition.ConfiguredFormDialogDefinition], property is not assigned: /

dialog: rssaggregator:planetFeeds
from jcr
at /modules/rssaggregator/dialogs/planetFeeds
Source data processing problem: Property [name] not found in class [info.magnolia.ui.dialog.definition.ConfiguredFormDialogDefinition], property is not assigned: /

dialog: rssaggregator:feedStatistics
from jcr
at /modules/rssaggregator/dialogs/feedStatistics
Source data processing problem: Property [name] not found in class [info.magnolia.ui.dialog.definition.ConfiguredFormDialogDefinition], property is not assigned: /

dialog: rssaggregator:feedSubscriptions
from jcr
at /modules/rssaggregator/dialogs/feedSubscriptions
Source data processing problem: Property [name] not found in class [info.magnolia.ui.dialog.definition.ConfiguredFormDialogDefinition], property is not assigned: /

dialog: rssaggregator:feedList
from jcr
at /modules/rssaggregator/dialogs/feedList
Source data processing problem: Property [name] not found in class [info.magnolia.ui.dialog.definition.ConfiguredFormDialogDefinition], property is not assigned: /

dialog: rssaggregator:feedSyndication
from jcr
at /modules/rssaggregator/dialogs/feedSyndication
Source data processing problem: Property [name] not found in class [info.magnolia.ui.dialog.definition.ConfiguredFormDialogDefinition], property is not assigned: /
  • /modules/rssaggregator/dialogs/planetFeeds@name
  • /modules/rssaggregator/dialogs/combinedFeed@name
  • /modules/rssaggregator/dialogs/feedStatistics@name
  • /modules/rssaggregator/dialogs/feedSyndication@name
  • /modules/rssaggregator/dialogs/feedSubscriptions@name
  • /modules/rssaggregator/dialogs/feedList@name

The selected attribute from CheckboxFieldDefinition was removed a long time ago (MGNLUI-1636). However, the property is still around in many bootstrap files. It should be removed.

dialog: rssaggregator:planetFeeds
from jcr
at /modules/rssaggregator/dialogs/planetFeeds
Source data processing problem: Property [selected] not found in class [info.magnolia.ui.form.field.definition.CheckboxFieldDefinition], property is not assigned: /form/tabs/tabMain/fields/showFeed

app: rssAggregator
from jcr
at /modules/rssaggregator/apps/rssAggregator
Source data processing problem: Property [selected] not found in class [info.magnolia.ui.form.field.definition.CheckboxFieldDefinition], property is not assigned: /subApps/detail/editor/form/tabs/mainTab/fields/planetFeed
  • /modules/rssaggregator/dialogs/planetFeeds/form/tabs/tabMain/fields/showFeed@selected
  • /modules/rssaggregator/apps/rssAggregator/subApps/detail/editor/form/tabs/mainTab/fields/planetFeed@selected


 Comments   
Comment by Jan Haderka [ 08/Dec/16 ]

so all we need to do is remove this prop in update task right? I'm so looking forward to the time when this type of issues are the only ones we have

Comment by Maxime Michel [ 08/Dec/16 ]

No, I'm sorry, the way I created those tickets wasn't very clever. I've started going through the list to improve them, will keep at it today.

Generated at Mon Feb 12 07:06:40 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.