[MGNLRSSAGG-33] Remove the html tags that come from the rss items descriptions Created: 23/Apr/10  Updated: 05/Apr/11  Resolved: 05/Apr/11

Status: Closed
Project: Magnolia RSS Aggregator Module
Component/s: None
Affects Version/s: 1.1
Fix Version/s: 1.1.2

Type: Improvement Priority: Trivial
Reporter: Teresa Miyar Assignee: Zdenek Skodik
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
duplicate
duplicates MGNLRSSAGG-25 HTML Code within RSS description (tex... Closed
relation
is related to MGNLSTK-683 Remove html tags at descriptions of r... Closed
supersession
is superseded by MGNLRSSAGG-47 Improve HTML removal in feed ftl's Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Item descriptions from rss feeds come with html tags that when shortening the description to display in the paragraphs some of this tags are not closed, causes a estrange rendering plus a not well formed html page. Fix i've been using in the freemarker template is adding the following:

description?replace("</?[^>]+(>|$)", "", "r") it could also be added to the models



 Comments   
Comment by Zdenek Skodik [ 02/Sep/10 ]

both models (FeedListAction, CombinedFeedAction) used by rss paragraphs are deprecated so let's fix it at template scripts level.

Comment by Felix Rabe [ 05/Apr/11 ]

I've committed some improvements to the feed ftl template files concerning the regular expression in use.

Comment by Zdenek Skodik [ 05/Apr/11 ]

Felix, imho it's a bit of mess - you should file a separate ticket and commit to it rather then reopen the ticket which commits were already released. Also post-release changing of Fixed version/s field list doesn't seem to be a right course of action.

Comment by Felix Rabe [ 05/Apr/11 ]

Reverted all my changes to this issue. See MGNLRSSAGG-47. Consider these commits as belonging to MGNLRSSAGG-47:

  • Trunk:
    • r43516 – MGNLRSSAGG-33 Feed ftl's: Make regexp pattern more reliable
    • r43524 – MGNLRSSAGG Improve feed ftl's
    • r43541 – MGNLRSSAGG-33 Feed ftl's: Make regexp pattern even more reliable
    • r43543 – MGNLRSSAGG-33 Feed ftl's: Remove HTML code once, and before using ?length and ?substring builtins
    • r43571 – MGNLRSSAGG Easier regex
    • r43627 – MGNLRSSAGG-33 Feed ftl's: Remove partial HTML entities again after taking substring of description
  • 1.1 branch:
    • r43517 – MGNLRSSAGG-33 Feed ftl's: Make regexp pattern more reliable (backport of r43516)
    • r43525 – MGNLRSSAGG Improve feed ftl's (backport of r43524)
    • r43542 – MGNLRSSAGG-33 Feed ftl's: Make regexp pattern even more reliable (backport of r43541)
    • r43544 – MGNLRSSAGG-33 Feed ftl's: Remove HTML code once, and before using ?length and ?substring builtins (backport of r43543)
    • r43572 – MGNLRSSAGG Easier regex (backport of r43571)
    • r43628 – MGNLRSSAGG-33 Feed ftl's: Remove partial HTML entities again after taking substring of description (backport of r43627)
Generated at Mon Feb 12 07:04:51 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.