[MGNLRSSAGG-48] Superfluous spaces in feed ftl's Created: 27/Apr/11  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia RSS Aggregator Module
Component/s: None
Affects Version/s: 1.1.3, 1.2.1
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Felix Rabe Assignee: Felix Rabe
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screen shot 2011-04-27 at 2.14.39 PM.png    
Issue Links:
relation
supersession
supersedes MGNLRSSAGG-47 Improve HTML removal in feed ftl's Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

My fixes for MGNLRSSAGG-47 introduced spaces where there should be none. The attached screenshot is the "On the Blogs" part of the current (2.3/2.4) corporate website, http://www.magnolia-cms.com/. (One space is caused by the blog post, not by the tag removal, and thus not pointed at in the screenshot.) The problem is that all tags are converted to a space (" "). In some situations, that is not appropriate, and the result is ugly.

The original solution tackled the case of "... paragraph.</p><h1>Heading" becoming "... paragraph.Heading".

Solution proposal: Change:

?replace("</?[^>]*(>|$)|&nbsp;?|&#?[0-9A-Za-z]*$", " ", "r")

into:

?replace("</[^>]*><[^/>]*>|&nbsp;?", " ", "r")?replace("</?[^>]*(>|$)|&#?[0-9A-Za-z]*$", "", "r")

such that "</x><y>" and "&nb​sp;" become " " (one space character), whereas any other tags, and end-of-string (partial) entities become "" (i.e. removed).



 Comments   
Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 07:05:00 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.