[MGNLRSSAGG-53] Bootstrap and mgnl-files folder not getting updated as part of delta-updates on new deploy. This leads to files not getting copied into docroot correctly and ftl(s) referring to RSS Icons endup with broken links to gif. Created: 01/Dec/11 Updated: 02/May/12 Resolved: 13/Dec/11 |
|
| Status: | Closed |
| Project: | Magnolia RSS Aggregator Module |
| Component/s: | None |
| Affects Version/s: | 1.2.1 |
| Fix Version/s: | 1.2.2, 1.3 |
| Type: | Bug | Priority: | Major |
| Reporter: | Rory Gibson | Assignee: | Ondrej Chytil |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | resources, rssaggregator | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
ubuntu 11.11, apache-tomcat 6.x |
||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Patch included: |
Yes
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Description |
|
The general root cause of this problem is that when doing a redeploy of web-application, without clearing down the DB, it is expected that the mgnl-files folder expansion task is re-executed and files are copied back into the cleared folder. However, it seems that ModuleManagerImpl's checkForInstallOrUpdates excludes all delta tasks for any module which hasn't had a version change on redeploy. Problem is specifically with the docroot folder which results in broken references to any resources not created post redeploy. This is not good because this means we cannot be sure the updates made to module are going through and consistent. Specifically w.r.t the RSS Aggregator module, the problem is that it has resources such has images (gifs) when changed or missing in the original deploy are not getting updated on redeploy. In order to avoid this issue, we think these should be moved into mgnl-resources instead (as most other resources are expected there by convention). I'm attaching the patch that does the above with this report. |
| Comments |
| Comment by Jan Haderka [ 02/Dec/11 ] |
|
JSP file was just emptied when applying patch in |