[MGNLRSSAGG-61] Provide an archive of imported feeds for later use Created: 12/Feb/13 Updated: 06/Dec/13 Resolved: 13/May/13 |
|
| Status: | Closed |
| Project: | Magnolia RSS Aggregator Module |
| Component/s: | None |
| Affects Version/s: | 1.3.4 |
| Fix Version/s: | 1.4 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Lars Fischer | Assignee: | Lars Fischer |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | planet | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
To provide a history of already imported feeds and to generate statistics (like a top authors list), we need to store imported feeds permanently. We should also provide mechanisms to avoid having to many nodes under a certain tree and we must also avoid duplicating data when re-fetching feeds. |
| Comments |
| Comment by Federico Grilli [ 21/Mar/13 ] |
|
Talked to Philipp and, alas!, we agreed to reopen this ticket and revert its commits due to a Maven cyclic dependency it introduces between rssaggregator and stk. Basically, rssaggregator now needs stk for the new features while stk already depended on rssaggregator for PageSyndicator. |
| Comment by Lars Fischer [ 22/Mar/13 ] |
|
I changed the code and removed the dependency on STK so the problem should go away. |
| Comment by Jan Haderka [ 17/Apr/13 ] |
|
Restore the coverage threshold. While it's ok to lower it during development of new feature, it should have never got committed and it's not ok to release such massive feature without any tests at all. |
| Comment by Lars Fischer [ 08/May/13 ] |
|
Restored clover threshold, there are more unit tests now. I will add more when improving data selection. |
| Comment by Jan Haderka [ 10/May/13 ] |
|
related commit: http://git.magnolia-cms.com/gitweb/?p=modules/rssaggregator.git;a=commitdiff;h=019381dc395e26a4ec7c4e152cbc9545d643446f Reopening since port to master is missing. |
| Comment by Lars Fischer [ 13/May/13 ] |
|
Re-added clover threshold setting to master branch. See http://git.magnolia-cms.com/gitweb/?p=modules/rssaggregator.git;a=commit;h=ea01045ae9e605327fad6722554f5a1c7f2c82fc |