[MGNLRSSAGG-67] Filter conditions are not working properly Created: 19/Feb/13  Updated: 12/Jun/14  Resolved: 12/Jun/14

Status: Closed
Project: Magnolia RSS Aggregator Module
Component/s: rss_importer
Affects Version/s: 1.3.4
Fix Version/s: 2.2.4, 2.3

Type: Bug Priority: Critical
Reporter: Lars Fischer Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: rssaggregator
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLRSSAGG-60 Filters feature does not work as docu... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

When applying several filters then they'll only work with some of the conditions.

The 'OR' condition can never work because the main include condition is always set to true at the beginning of the 'include' method in AggregateFilter.java. When matching a single String in the matchSingleString method with an 'OR' condition, the result will always be true.

Also, the filters are not applied to the "description" attribute (the main content) because the content of the description is assigned and saved AFTER filtering already has happened (so the filter for "description" is never run).



 Comments   
Comment by Christoph Meier [ 12/Jun/14 ]

RenameFilterFieldsPropertiesTask#properties : the 1st key-value-pair of the immutable map is incorrect.
Instead of "configurations", "configuration" it should be "conditions", "condition"

Comment by Christoph Meier [ 12/Jun/14 ]

RenameFilterFieldsPropertiesTask is not working.
On the Unit-test, but not on the running system.

Comment by Christoph Meier [ 12/Jun/14 ]

Fixed RenameFilterFieldsPropertiesTask and RSSAggregatorVersionHandlerTest

Generated at Mon Feb 12 07:05:12 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.