[MGNLRSSAGG-8] Node locked exception Created: 08/Dec/08  Updated: 09/Feb/15  Resolved: 03/Feb/09

Status: Closed
Project: Magnolia RSS Aggregator Module
Component/s: None
Affects Version/s: 1.0
Fix Version/s: 1.0

Type: Bug Priority: Major
Reporter: Olivier Marti Assignee: Jan Haderka
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Magnolia EE 3.6.3, with Data module 1.2.1


Attachments: Text File MGNLRSSAGG-8.patch     Text File error.log    
Issue Links:
relation
is related to MGNLRSSAGG-9 Error: ImportHandler is still running Closed
is related to MGNLRSSAGG-11 ImportHandler [rssaggregator] is stil... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

When trying to import new data I get a constant error that the nodes are locked, which I assume is also preventing the automated import/activation from working properly.
See attached the log fie. I will observe that the next few days and report back with more information.



 Comments   
Comment by Rob van der Linden Vooren [ 20/Jan/09 ]

I have used the RSS Aggregator module myself and ran into this issue, as well as MGNLRSSAGG-8. I have rewritten the RSSImportHandler to fix the mentioned issues. What is the proposed way to contribute my fixes back for review?

Comment by Jan Haderka [ 20/Jan/09 ]

create a patch and attach it to the issue.
Thanks.

Comment by Magnolia International [ 20/Jan/09 ]

( http://documentation.magnolia-cms.com/contribute.html#WriteCode )

Comment by Rob van der Linden Vooren [ 21/Jan/09 ]

Attached patch that as far as I can tell fixes MGNLRSSAGG-8 and MGNLRSSAGG-9.

I moved RSSFeedImportHandler to a deeper package, I hope this change reflects in the patch (meaning the 'old' version should not exist anymore)
The main cause for the issues was a loop that spawning threads in an non-managed fashion.

Although the multithreaded code was probably written for performance reasons, fetching of feeds in a single thread would suffice for situations where the number of feed channels to retrieve is not large and the time window between update checks is not small; my implementation provides such a fetcher.

Due to the rewrite, a multithreaded fetcher is easily pluggable. A suggestion for implementing such a fetcher is using the utility classes in the new concurrent library; Eg. ExecutorService.

Comment by Jan Haderka [ 03/Feb/09 ]

Applied patch with few modifications. Mainly in the section dealing with loading classes, using normal magnolia configuration. To add a custom fetcher you just have to add fetcherClass node data to the importer and it will be set on the importHandler automatically. You can look at the subversion tab for details.
Thanks for the patch.

Generated at Mon Feb 12 07:04:35 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.