[MGNLSCH-57] CommandJob should not depend on UI (via MessageManager) Created: 13/May/15  Updated: 20/Jun/16  Resolved: 30/Jul/15

Status: Closed
Project: Scheduler
Component/s: None
Affects Version/s: None
Fix Version/s: 2.2.1

Type: Improvement Priority: Critical
Reporter: Magnolia International Assignee: Espen Jervidalo
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLSCH-65 Exceptions in scheduled jobs are not ... Closed
dependency
is depended upon by MGNLUI-3510 Clean up async action execution Closed
supersession
supersedes MGNLSCH-56 Inject a Provider<SimpleTranslator> i... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Sprint: Sprint 4 (Basel)
Story Points: 1

 Description   

Among other things, that would mean that we should be able to send "warning" or error type of events without translating the messages (thus not having to care about context and which locale is used)

TODO: report or link tickets in UI:

  • the wrong locale is used (since we translate with the locale of the context where the error happens, not the locale of the "reader")
  • use event bus for those messages instead of directly depend on MessageManager
  • enable MessageManager to work with untranslated messages (which often need parameters)

Tentatively scheduling for 2.2 but we can live with the existing workaround for a while longer.



 Comments   
Comment by Espen Jervidalo [ 31/Jul/15 ]

We don't even need to use the event bus. You can pass along "results" of the job execution in the JobExecutionContext. If something goes wrong, we add the exception.

Comment by Espen Jervidalo [ 04/Aug/15 ]

commit under 58601a93456c949bce70c90b8b2a3501b2b37d1d

Generated at Mon Feb 12 10:45:28 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.