[MGNLSITE-28] Provide an app to CRUD themes Created: 11/Aug/15  Updated: 11/Jan/16  Resolved: 22/Dec/15

Status: Closed
Project: Magnolia Site Module
Component/s: app
Affects Version/s: None
Fix Version/s: 1.0.4

Type: Task Priority: Neutral
Reporter: Philip Mundt Assignee: Oanh Thai Hoang
Resolution: Fixed Votes: 1
Labels: pm, site
Remaining Estimate: 5h 55m
Time Spent: 4d 2h 5m
Original Estimate: 5d

Attachments: XML File config.modules.site-app.apps.theme.xml     XML File config.modules.ui-admincentral.config.appLauncherLayout.groups.stk.apps.theme.xml    
Issue Links:
Cloners
is cloned by MGNLSTK-1518 Replace themes app in STK with one fr... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Sprint: Saigon 25
Story Points: 8

 Description   

STK used to have an app to create/read/update and delete themes. We should also provide the default site module with such an app.

There are additional information:

  • theme support classes go to site module, theme-app goes to site-app module
  • theme-app becomes a second subapp of the site app (like in security, mail or cache apps)
  • theme-subapp will indeed be bootstrapped (in single file + bootstrap task in VH)
  • site app will replace by site subapp (extra install task to guarantee ordering, renaming + tasks in VH)


 Comments   
Comment by Christian Ringele [ 13/Aug/15 ]

Work around:
Here the two bootstrap files needed to add them "manually" if the App is needed:
config.modules.site-app.apps.theme.xml
config.modules.ui-admincentral.config.appLauncherLayout.groups.stk.apps.theme.xml

For Product:
Attention, they contain hard-coded labels.
The rest is 1:1 the Site App with the needed change

Comment by Mikaël Geljić [ 14/Dec/15 ]
  • define as independent magnolia module, or new sub-module of site, or just an app inside site module
  • carry/relocate/deprecate the theme install tasks and VH along (see additional notes on concept page
Comment by Oanh Thai Hoang [ 17/Dec/15 ]

The estimate time includes 2 days for reviewing process already

Comment by Sang Ngo Huu [ 21/Dec/15 ]

I did an investigation and see that info.magnolia.module.templatingkit.setup.ThemeInstallTask and info.magnolia.module.templatingkit.setup.ThemeVersionHandler cannot be moved to site module:

  • As I know that processedResources is deprecated from 5.4 we just make it backward compatibility. We don't need to install resources from 5.4, so this class should be in legacy STK
  • ThemeInstallTask class used STKResourceModel class which deeply depend on STK
Generated at Mon Feb 12 07:11:58 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.