[MGNLSITE-43] Site aware renderer for any renderer Created: 02/Oct/15  Updated: 09/Feb/16  Resolved: 08/Feb/16

Status: Closed
Project: Magnolia Site Module
Component/s: None
Affects Version/s: 1.0.2
Fix Version/s: 1.0.5

Type: Improvement Priority: Neutral
Reporter: Tobias Mattsson Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 5m
Original Estimate: Not Specified

Attachments: Java Source File SiteAwareJspRenderer.java    
Issue Links:
Relates
relates to MAGNOLIA-6530 Freemarker and Site renderer and not ... Closed
relates to MGNLSITE-42 Allow site definition template availa... Closed
relates to MGNLSITE-33 SiteAwareTemplateAvailability only wo... Closed
causality
is causing MGNLCAT-164 No need to install ctx attributes on ... Closed
is causing MGNLDAM-637 No need to install ctx attributes on ... Closed
is causing MGNLDEMO-142 No need to install ctx attributes on ... Closed
is causing MGNLIMG-182 No need to install ctx attributes on ... Closed
is causing MTE-77 No need to install ctx attributes on ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Date of First Response:
Sprint: Kromeriz 30
Story Points: 2

 Description   

It is currently only possible to use the template prototype configured on a site when using Freemarker templates. This is because the site module only has one renderer that is based on FreemarkerRenderer.

To support JSPs we need a SiteAwareJspRenderer. It would need to have a specific renderType, for instance site-jsp.

Info

The main functionality that the SiteAwareFreemarkerRenderer adds is the capability to merge page's template definition with a prototype template definition from the site and/or a fallback template definiton when specified.

Possible solutions

  1. Duplicating functionality from SiteAwareFreemarkerRenderer
  2. Create a new wrapped renderer that will delegate to another renderer, here the freemarker or jsp renderer


 Comments   
Comment by Roman Kovařík [ 04/Feb/16 ]

For release notes:

  • No need to implement an site aware renderer for your custom renderers. You can just use info.magnolia.module.site.renderer.SiteAwareRendererWrapper and set it the property wrappedRendererType==YOUR_RENDERER_NAME.
  • Site aware jsp renderer added by default (site-jsp).
Comment by Roman Kovařík [ 08/Feb/16 ]

Reopened: unused property type on update: https://jenkins.magnolia-cms.com/view/Migration/job/int_migration-tests_5.4-to-5.4.x-no-travel-branch/Diff_Reports/

Generated at Mon Feb 12 07:12:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.