[MGNLSITE-57] Decide if use only name as theme reference or move to module:relative/path/themeName reference Created: 09/Mar/16  Updated: 15/Mar/16  Resolved: 15/Mar/16

Status: Closed
Project: Magnolia Site Module
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Evzen Fochr Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Account:
Epic Link: LD: create an entire site

 Description   

we choose the name-as-id strategy (over module+relativePath)



 Comments   
Comment by Christopher Zimmermann [ 09/Mar/16 ]

I think we should stick with the name for now.

I do appreciate that the question is raised though. I don't like the inconsistancies. (In the future could all referencing take place by both name and id techniques?)

Comment by Evzen Fochr [ 09/Mar/16 ]

It is not possible to reference by both, because if you use name you cannot differ between templates with same name under different modules. Of course we try to be backwards compatible with exception if somebody use name reference to theme in registry that is there with same name but with different id we serve first we found.

Comment by Philip Mundt [ 09/Mar/16 ]

I've placed my vote already: I'm for the name-as-id.

  • We're not introducing a new mechanism to reference themes (another thing that devs will have to change/adapt)
    • Migration should be kept to a minimum (moving existing themes is already enough)
  • Working with themes in templates stays simple
    • Have you checked how the theme-resources are linked with the new id?
    • Working with dialogId or templateId when templating is only a last resort
  • I don't see the need of +5 themes in an instance (maybe there are a few cases, but it will mostly be the site that varies)
Generated at Mon Feb 12 07:12:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.