[MGNLSITE-60] Themes added by using the old mechanism (backwards-compatible) are not decorateable Created: 18/May/16 Updated: 09/Feb/17 Resolved: 02/Sep/16 |
|
| Status: | Closed |
| Project: | Magnolia Site Module |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.1 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Philip Mundt | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Epic Link: | LD: create an entire site | ||||||||||||
| Sprint: | Basel 59 | ||||||||||||
| Story Points: | 3 | ||||||||||||
| Description |
|
When themes are placed in config:/modules/site/config/themes/<theme-name> they are not decorateable. This is due to backwards-compatible code setting the raw-view of the theme to an empty String when it's added to the registry. When adding the theme to config:/modules/<my-module>/themes/<theme-name> everything works according to plan. When added by using the new mechanism however, themes will not show up in the themes app (see Implemented solutionInstead of creating the theme with en empty raw view, we now determine the raw view from the theme node itself – enabling decoration of that theme. |
| Comments |
| Comment by Philip Mundt [ 02/Sep/16 ] |
|
Be aware that if you want to decorate a theme that is registered via the deprecated method, you need to specify the destination module as site. E.g. for the travel-demo: |