[MGNLSITE-66] page definitions shouldn't require a pages folder as ancestor Created: 13/Jul/16  Updated: 19/May/22  Resolved: 19/May/22

Status: Closed
Project: Magnolia Site Module
Component/s: None
Affects Version/s: 1.0.7
Fix Version/s: None

Type: Improvement Priority: Minor
Reporter: Matthias Müller Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

The prerequisite for page definitions (as well as component definitions) is to be somewhere under a folder/contentNode 'templates', which is right below the (light-)module.

The new Template Availability Features 'enableAll' and 'enableAllWithRenderType' introduce the new requirement of page definitions being under a 'pages' folder/contentNode, which requires to be right below the mentioned 'templates' folder/contentNode.

Therefore <module-name>/templates/pages/someTemplateId will work while <module-name>/templates/some/folder/structure/someTemplateId will not.

This additional requirement is hard coded in info.magnolia.module.site.templates.ConfiguredSiteTemplateAvailability#142:

StringUtils.substringAfter(templateDefinition.getId(), ":").startsWith("pages/")

I see not valid reason for creating any further (not backwards compatible) conventions like this. Same goes for components, which hopefully never have to be in a 'components' folder to be "fully functional". Therefore i hope, that this new 'convention' is removed again.



 Comments   
Comment by Roman Kovařík [ 19/May/22 ]

Hello,

This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you.

Thank you,
The Magnolia Team

Generated at Mon Feb 12 07:12:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.