[MGNLSLOCK-5] Module naming inconsistency Created: 02/Dec/10  Updated: 26/May/15  Resolved: 19/May/15

Status: Closed
Project: Magnolia Soft Locking Module
Component/s: None
Affects Version/s: None
Fix Version/s: 2.5

Type: Task Priority: Major
Reporter: Magnolia International Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

All(*) our modules are named (in terms of module descriptor <name>)

  • using hyphens
  • following their Maven artifactId (minus the magnolia-module prefix)

We should thus rename softLocking to soft-locking. This can be achieved by hooking deeper in the ModuleVersionHandler (i.e the default behavior would always consider this an install, we need to make it "believe" it's an update)

(*) except for the soon-to-be-deprecated-or-dropped adminInterface and fckEditor



 Comments   
Comment by Espen Jervidalo [ 08/May/15 ]

This won't work. When changing the module name, it won't find a former version of the module.

Comment by Espen Jervidalo [ 19/May/15 ]

For QA: Add soft-locking module 2.0.3 to ee-bundle, run install, shutdown. Change version to 2.5-SNAPSHOT and re-run installation.

Comment by Federico Grilli [ 21/May/15 ]

.addTask(new RemoveNodeTask("Remove soft-locking config node", "Removes no longer needed soft-locking config-node.", RepositoryConstants.CONFIG, "/modules/soft-locking/config"))
at https://jira.magnolia-cms.com/secure/bbb.gp.gitviewer.Commit.jspa?repoId=125&commitId=d74f089f2ccf1ffd27993d85d8ae4caba82f18dd#bbb-gp-codereview-diff__src/main/java/info/magnolia/module/softlocking/setup/SoftLockingModuleVersionHandler.java

Shouldn't the path to be removed be /modules/softLocking/config ?

Generated at Mon Feb 12 07:14:23 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.