[MGNLSLOCK-68] Soft locking 3.1 should depend on pages-app module Created: 22/Mar/23  Updated: 17/Jul/23  Resolved: 04/Apr/23

Status: Closed
Project: Magnolia Soft Locking Module
Component/s: None
Affects Version/s: 3.1.2
Fix Version/s: 3.1.3

Type: Bug Priority: Neutral
Reporter: Richard Gange Assignee: Miguel Martinez
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to BUILD-1032 Can not install 3.1.x soft-locking mo... Closed
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Release notes required:
Yes
Documentation update required:
Yes
Date of First Response:
Epic Link: AuthorX Maintenance
Story Points: 1
Team: AuthorX
Work Started:
Approved:
Yes

 Description   

The module descriptor was not updated when the module was updated for the new UI (see MGNLSLOCK-55). It still depends on the legacy pages module rather than the new pages-app module.



 Comments   
Comment by Sebastian Pertinger [ 14/Jul/23 ]

This causes several warnings now for us since magnolia-personalization-compatibility is still a core module dependency. How did you guys handle that?

 

2023-07-14 12:50:19,454 INFO  fig.source.yaml.decoration.YamlDefinitionDecorator: Applied YAML file based decorator from [/personalization-components-compatibility/decorations/pages/apps/pages/pages.subApps.detail.actionbar.sections.componentActions.groups.variantActions.yaml] to definition provider [[app] definition [pages] with reference id: [pages] from module [pages] at [pages]]
2023-07-14 12:50:19,454 WARN  fig.source.yaml.decoration.YamlDefinitionDecorator: 0 major and 1 minor problems have been encountered
2023-07-14 12:50:19,454 WARN  fig.source.yaml.decoration.YamlDefinitionDecorator: 
Severity type:   MINOR 
Title:           pages/subApps/detail/statusBar/extensions/softLocking/extensionClass: [Definition resolution] - Source data processing problem 
Problem details: Failed to resolve a class property due to a missing class: [info.magnolia.module.softlocking.extension.SoftLockingExtension]
Generated at Mon Feb 12 07:15:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.