[MGNLSSO-291] Subclassing Pac4jConfigProvider from SSO module breaks Magnolia startup of fresh start when no repositories exist yet Created: 07/Jun/23  Updated: 15/Jun/23  Resolved: 15/Jun/23

Status: Closed
Project: Single Sign On
Component/s: sso-connector
Affects Version/s: 3.1.4
Fix Version/s: 3.1.5

Type: Bug Priority: Neutral
Reporter: Viet Nguyen Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Java Source File ExtraPac4jConfigProvider.java     XML File extended-sites.xml     Text File sso_startup_error_full.log    
Issue Links:
Relates
relates to MGNLSSO-265 Possibility to implement custom SsoCo... Closed
causality
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: SSO maintenance
Team: AdminX

 Description   

Steps to reproduce

  1.  Extends Pac4jConfigProvider by a very simple one like this ExtraPac4jConfigProvider.java in a custom Java module such as extended-sites.xml
  2.  Start up a fresh version of Magnolia with the module in the bundle

.. Logs, screenshots, gifs...

Expected results

  • System works by design

.. Justify non-trivial expectations with a link to a doc or a relevant discussion.

Actual results

Workaround

  • Let it finish the start up task, then stop and start again the instance

Development notes

  • Pac4jConfigProvider constructor start its configuration monitoring on "resources" workspace before the workspace being created. Moving these initiation stuffs to the point after the workspace created would help. This should be in the SSO module's start up function info.magnolia.sso.SsoModule.start(ModuleLifecycleContext)


 Comments   
Comment by Viet Nguyen [ 15/Jun/23 ]

Issue does not happen anymore in 3.1.5, please also note that the class has been changed and restructured. Related to the fix in MGNLSSO-265.
cc: efochr

Generated at Mon Feb 12 10:52:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.