[MGNLSTK-1012] Update Pom dependency & Version Handler in order to use the new migration process Created: 18/Oct/12  Updated: 02/Dec/12  Resolved: 30/Nov/12

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: None
Affects Version/s: 2.0.6
Fix Version/s: 2.0.7

Type: Task Priority: Neutral
Reporter: Eric Hechinger Assignee: Eric Hechinger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLMIGRATION-116 Migrated Modules configuration: STK Closed
is related to MGNLSTK-1013 Update Pom dependency & Version Handl... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

Add dependency on the POM to the migration module (STK only as demo project bootstrap new content).

Create a new version handling task in order to migrate configuration (STK).

Adapt the Parent pom in order to use the correct version of depending modules also touched by the migration.



 Comments   
Comment by Jan Haderka [ 26/Nov/12 ]

STK pom

+      <version>1.2.0-SNAPSHOT</version>

please do not use trailing zero in version number. We always skipped those in the past. Starting to introduce them now causes issues when resolving dependencies during release.

Update task for version 2.0 was added in version 2.0.7 - if someone updates from some version in between, task will be never executed. Is this correct? If so it should be explained in the ticket. Also think of a combination when someone tries to install this version with old version of migration module - i think it will produce conflict and as such should be either checked via install condition or via declared dependency in module descriptor.

Lots of bootstrap files were added, but do not seem to be loaded during update. Are they really necessary only on installation and all changes introduced in those files are handled by StkMigrationTask?

Comment by Jan Haderka [ 26/Nov/12 ]

btw, port to 2.5 (master) branch is missing.

Comment by Eric Hechinger [ 30/Nov/12 ]

Dependency to the migration module was changed (in the module descriptor) to enforce dependency to migration module 1.2 in case of installation of STK 2.0.7.

Add a migration task in the version handler in order to migrate the STK module from 4.4.6 to 4.5.7 and higher.
Magnolia 4.4.6 shipped STK 1.4.6
Magnolia 4.5.0 shipped STK 2.0

If a Magnolia instance is updated from 4.4.6 to 4.5.7, the version handler (DeltaBuilder.update("2.0.0", "")) will take care of the migration of the module.
The migration task will also bootstrap the files defined in mgnl-bootstrap/migration.
If a Magnolia instance was already updated let say from 4.4.6 to 4.5.6 (Version 2.0.6 of the STK module) and we want now to update to Magnolia 4.5.7,
in this case, the version handler will not run the migration task.
Migration already took place during update from 4.4.6 to 4.5.6. and should not run again.
Bootstrap files defined under mgnl-bootstrap/migration where already handled during the migration from 4.4.6 to 4.5.6 by the 1.1 Migration module tasks. They shouldn't be boutstrapped again.
This is exactly what we expected.

Comment by Eric Hechinger [ 30/Nov/12 ]

Same changes are performed to master (MGNLSTK-1013).

Generated at Mon Feb 12 07:32:32 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.