[MGNLSTK-1041] Reusability: unnecessary dependencies on STK model classes Created: 05/Dec/12  Updated: 02/Jul/18  Resolved: 02/Jul/18

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: templates
Affects Version/s: 2.0.6
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Magnolia International Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

When extending an STK template, one has to extend info.magnolia.module.templatingkit.templates.pages.STKPage if they want to add custom areas or configuration. That's fair.

But if the custom template also needs a model, it seems unnecessary that they also have to extend info.magnolia.module.templatingkit.templates.pages.STKPageModel - because i.e htmlHeader.ftl uses pageModel.logoImageLink and pageModel.site.

It seems to be cluttering a class that should really be about "business logic" with layout logic. Some of these methods would probably be better off in stkfn... but some cases are debatable. Just leaving this here as food for thought. (Also because there is a lot of duplication or close-but-not-quite-the-same similarity between STKPageModel and functions of stkfn.



 Comments   
Comment by Jan Haderka [ 02/Jul/18 ]

STK have been deprecated in September 2017. As part of this project nearing end-of-life, we are not planning to fix any of the existing issues except for the critical security issues. For more details, please consult documentation.

Generated at Mon Feb 12 07:32:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.