[MGNLSTK-1064] Update task breaks JS configuration for aggregated scripts Created: 07/Jan/13  Updated: 15/Jul/15  Resolved: 06/Feb/13

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: None
Affects Version/s: 2.0.7
Fix Version/s: 2.0.9, 2.5

Type: Bug Priority: Major
Reporter: Natascha Desmarais Assignee: Jaroslav Simak
Resolution: Fixed Votes: 1
Labels: aggregated_scripts, processedJS, scriptloader, scriptloader_libraries, scriptloader_plugin
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLSTK-818 JavaScript Libraries should be update... Closed
dependency
depends upon MGNLRES-55 Add posibility to preserve resource p... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

A bug introduced in MGNLSTK-818 turns all processed javascripts into simple javascripts - this makes the aggregated scripts of STK not work anymore and the whole (teaser) functionality is lost.

The faulty line is in

info.magnolia.module.templatingkit.setup.STKModuleVersionHandler
.addTask(new InstallResourcesTask("/templating-kit/js/.*.js", "resources:js", false))

on line 194 (delta task for 2.0.7).
See info.magnolia.module.templatingkit.setup.InstallSTKResourcesTask for an overview of special scripts.



 Comments   
Comment by Jan Haderka [ 14/Jan/13 ]

I think the issue is not really fixed. Just moved one level down. You should have a task that checks if the script already exists and if so you should upload new code w/o changing the type of it.

Also what you are fixing here is just the original cause. What about all the ppl who already installed this version of STK. How are you going to fix the issue for them? There should be a task in 2.0.9 version that one by one checks for type of all the scripts that were incorrectly reset before and fix it back.

Comment by Leo Lozes [ 14/Jan/13 ]

We had the same problem today upgrading to 4.5.7, all the processed JS were bootstrapped as simple Javascript.

Comment by Jaroslav Simak [ 14/Jan/13 ]

@Jan
yes, you are right, my "solution" was pretty silly. sorry.

@Leo
sorry for inconvenience, this should be fixed tomorrow

Comment by Jaroslav Simak [ 04/Feb/13 ]

Reopening issue because of missing update task in 2.0.x branch

.addTask(new InstallResourcesTask("/templating-kit/js/shims/swf/JarisFLVPlayer.swf", "resources:binary", true))
Comment by Natascha Desmarais [ 05/Feb/13 ]

Typo in the delta, it should be resources:binary (missing s)

I saw that this was already the case in the 2.0.7 release, so this will additionally need a delta task for 2.0.9 that sets the correct template id for the JarisPlayer swf. Not sure which is the appropriate fixVersion for 2.5, please set accordingly when fixing this.

Generated at Mon Feb 12 07:33:02 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.