[MGNLSTK-1087] ImagingSupport.resolveVariationName() should work like a proper css selector mechanism Created: 06/Feb/13 Updated: 02/Jul/18 Resolved: 02/Jul/18 |
|
| Status: | Closed |
| Project: | Magnolia Standard Templating Kit (closed) |
| Component/s: | None |
| Affects Version/s: | 2.0.6 |
| Fix Version/s: | 2.0.x |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Will Scheidegger | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | image, selector, variations | ||
| Remaining Estimate: | 1d | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | 1d | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Date of First Response: |
| Description |
|
CssSelectorBuilder builds a nice and long selector from the known css classes and ids in the definitions. Then ImagingSupport.resolveVariationName() simply maps the variations rule to this selector and returns the first variation which matches. This system does not correspond to how css selectors work (and therefore to what the users are used to). The resolving mechanism should not select the first but the best matching variation (IDs over classes, more matches over less). |
| Comments |
| Comment by Jan Haderka [ 02/Jul/18 ] |
|
STK have been deprecated in September 2017. As part of this project nearing end-of-life, we are not planning to fix any of the existing issues except for the critical security issues. For more details, please consult documentation. |