[MGNLSTK-1095] Escape values for rendering, don't escape already escaped values - 4.5 Created: 15/Feb/13 Updated: 02/Aug/13 Resolved: 28/Feb/13 |
|
| Status: | Closed |
| Project: | Magnolia Standard Templating Kit (closed) |
| Component/s: | templates |
| Affects Version/s: | 2.0 |
| Fix Version/s: | 2.0.9 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Roman Kovařík | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
Due to changes by
Cover the cases where are values still not escaped:
|
| Comments |
| Comment by Jan Haderka [ 19/Feb/13 ] |
|
Actually, all (or most anyway) of escaping should be done (and was in the past) by rendering engine. If this is not happening (and it seems to be the case) this issue should be re-fixed in rendering engine and not in the individual templates. I have suspicion that it is related to changes made for |
| Comment by Roman Kovařík [ 22/Feb/13 ] |
|
Node root = (Node)currentNode.getAncestor(startLevel); ... return new NavigationModel(root, currentNode, getVerticalLevel(), allOpen, rootIsHome); root node is unwrapped even if currentNode is. |
| Comment by Roman Kovařík [ 27/Feb/13 ] |
|
Port to master is registered under |
| Comment by Jan Haderka [ 27/Feb/13 ] |
|
Actually I think the title no longer matches what was really done in this issue. Could you please update it? |