[MGNLSTK-1162] multisite: expose a method to create link prefixes Created: 04/Jun/10 Updated: 16/Dec/14 Resolved: 29/May/13 |
|
| Status: | Closed |
| Project: | Magnolia Standard Templating Kit (closed) |
| Component/s: | None |
| Affects Version/s: | 2.0 |
| Fix Version/s: | 2.0.10 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Philipp Bärfuss | Assignee: | Jaroslav Simak |
| Resolution: | Fixed | Votes: | 3 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
The mechanism introduced to guarantee the site detection ( |
| Comments |
| Comment by Jan Haderka [ 01/Oct/12 ] |
|
While fixing this issue, review ALL code changes made for |
| Comment by Zdenek Skodik [ 28/Mar/13 ] |
|
IMHO we should not create localized link prefixes to resources when they still target the same css for instance, serve the same contents. The localized pattern should be removed from the linkPrefix. |
| Comment by Jan Haderka [ 23/May/13 ] |
|
STKSiteManager + public String getLinkPrefix(Node currentSite) { Either it is link to current site ( the one currently available in the context, in which case you don't need to pass site root node as a param, or it is link to any page in which case is the param name confusing. |
| Comment by Jan Haderka [ 23/May/13 ] |
|
Also inside of the method you call link util which will in turn call site manager ... This is unnecessarily complicated and would be a hell to debug later. Either you can get what you want w/o the round trip via link util, or. Maybe it is a clue that this method belongs there and not to site manager. |
| Comment by Jan Haderka [ 23/May/13 ] |
|
See comments above |
| Comment by Jaroslav Simak [ 29/May/13 ] |
|
resolved in related |