[MGNLSTK-1188] Uploaded i18n logo is not shown at all Created: 16/Apr/13  Updated: 24/Jul/13  Resolved: 15/Jul/13

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: controls
Affects Version/s: 2.0.9
Fix Version/s: 2.0.11

Type: Bug Priority: Neutral
Reporter: Milan Divilek Assignee: Roman Kovařík
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
relation
is related to MAGNOLIA-5197 Add I18nContentSupport.hasNode(Node c... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

If i18n is allowed for dam control then uploaded image for second language is not visible anywhere (home page, subpages). With dms image it works.

Step to reproduce:
1.Configuration - standard-templating-kit/dialogs/pages/home/stkHomeProperties/tabMain/logoImg add property i18n with value true
2.go to demo-project website and switch language to Deutch
3.in page dialog for Logo Image choose "Upload" and upload your own logo
4.save dialog
5.newly uploaded image isn't shown



 Comments   
Comment by Andreas Antener [ 05/Jun/13 ]

Just came across this issue after updating from 4.5.6 to 4.5.8. So it looks like the behaviour changed in either 4.5.7 or 4.5.8.

I don't know how many people use the i18n feature on images but this is a serious issue for us, please increase priority.

Comment by Roman Kovařík [ 13/Jun/13 ]

Port to master not needed - master doesn't use old DAM.

Comment by Jan Haderka [ 13/Jun/13 ]
 log.warn("Failed to determine locale of nodeData '{}' for '{}'.", new Object[] { nodeDataName, node, e });

That log message doesn't work. Unfortunately you can't use multiple params and printout exception like this, you will have to inline params in the message and have exception as only additional param to the message.

Comment by Roman Kovařík [ 15/Jul/13 ]

git commit:
https://git.magnolia-cms.com/gitweb/?p=modules/standard-templating-kit.git;a=commitdiff;h=d8ecd25a2787000a1d015292352bd75f693550fb

Comment by Jan Haderka [ 24/Jul/13 ]

I think this issue just highlights shortcoming of the I18nContentSupport interface. There should be hasNode(Node current, String childName) method added there to allow checking for existence rather then relying on PNFE.

Generated at Mon Feb 12 07:34:12 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.