[MGNLSTK-1196] stkContact template now exists twice and css is miss-styled for Main Content area Created: 19/Jun/13  Updated: 08/Jul/13  Resolved: 04/Jul/13

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: base system
Affects Version/s: 2.5
Fix Version/s: 2.5.1

Type: Bug Priority: Neutral
Reporter: Philip Mundt Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: quickwin
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

stkContact has been made available in the main content area [1], however stk stylesheets do not take account of this:

<dl class="tel">
  <dt><span class="type">work</span> Work</dt>
  <dd class="value">+41 (0)61 228 90 00</dd>
</dl>
<span class="type">work</span>

has to be hidden by CSS.

Option 1 (keep it available):
If this component should still be available in the main content area, plase consolidate duplicate ftl templates and add CSS.

Option 2 (remove component):
Remove duplicate template /templating-kit/components/content/contact.ftl and remove [1].

[1] /mgnl-bootstrap/standard-templating-kit/templates/pages/config.modules.standard-templating-kit.templates.pages.stkArticle.areas.main.areas.content.availableComponents.stkContact.xml

DECISION:
Keep it available in content area.



 Comments   
Comment by Christopher Zimmermann [ 28/Jun/13 ]

Removed redundant magnolia-module-standard-templating-kit/src/main/resources/templating-kit/components/content/contact.ftl

Updated components/teasers/contact.ftl to handle being in either extras or content area.

UPdated bootstrap for content.stkContact.xml to reference the teasers ftl file (instead of deleted one).

To Test

  • try adding a contact to a content area.
  • review a contact in an extras area.
Comment by Tobias Mattsson [ 04/Jul/13 ]

This requires an update task in the version handler.

Comment by Philip Mundt [ 04/Jul/13 ]

Added versionHandler and the respective test in STKModuleVersionHandlerTest.

Generated at Mon Feb 12 07:34:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.