[MGNLSTK-12] Horizontal Tabbed Extras + Teaser: CSS/JS is not behaving correct Created: 16/Dec/08  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Christian Ringele Assignee: Philipp Bärfuss
Resolution: Won't Do Votes: 0
Labels: concept1, mme_sprint3
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

I write here a summery of all style problems seen on the horizontal tabbed teaser + extras.

  • teaser (main-home) - Not showing correctly in a home page with floating:
    On a home page with floating activated the tabbed teaser isn't rendered correctly by the js.
    The border is dragged over the complete content width instead having the width of one column width
  • teaser (main-home&section) - Link List elements are dragged to the top besides the image:
    This behaviour we had on a normal extras teaser before. If the image is higher than the teaser text the links are dragged up to the text besides the image.
    If a link list title is set, the separation line (dot line) is overlapped by the image.
    The link list title is not shown below the image, it is dragged up to the teaser text.
    All this happens only, if the image is higher than the teaser text.
  • teaser (main-section) - not more than 5 tab elements are shown:
    In the section page the tabbed teaser shows only 5 tab items (more than the width if one line of tabs). The sixt item is shown within the html code, but not rendered by the js.
    Like this the "Add Tab-Item" Bar (New Bar) disappears after the 5th element, because the New Bar is the 6th list element.
    Because the element is not rendered, it can't be deleted -> no new bar anymore.
    If the same paragraph (containing more than 5 tab-items) is added to the home page, it shows all tab items.
    In the extras, if there are more tabs than on one width can be show, it renders them onto the second line. I guess this is not happening here.
  • teaser+extras (in general) - if no headline is defined top border is not correct:
    If no headline is defined, the nice round border is not rendered. It just renders the top corners with a 90degree angle instead of the nice rounded corner.


 Comments   
Comment by Boris Kraft [ 16/Dec/08 ]

If the tabs are more/longer than fit in a single line, tabs are moved below the first row of tabs. But there is no design for this, in other words it looks strange. I suggest that either we design for it, or we make sure tabs will remain in one line (in which case it would be best if they are just cut off)

Comment by Boris Kraft [ 16/Dec/08 ]

Actually, to just cut it off doesn't work all that well. This is what we do in the main section. If a tab text is too long, the "new tab" button will not be rendered. If it is even longer, the tab itself will not be rendered as well, so you do not see what is happening and you cannot get rid of the long tab (because it is not rendered at all).

This clearly is not cool.

I suggest to 1.) put the "add tab" button above the actual tabs, so it will always be displayed. Also it should just be a button, not a mini-edit bar. 2.) Really long titles should definitely not result in a tab not displaying. And adding more tabs than fit should simply display the added tabs in a second row even if it looks crappy, it is better than not displaying them at all.

Comment by Boris Kraft [ 16/Dec/08 ]

Another idea would be to add the "add tab" button on the actual tabbed teaser paragraph edit bar (in addition to its "delete, edit, move" buttons). This seems pretty intuitive and less clutter.

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 07:22:53 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.