[MGNLSTK-1225] Prevent NPEs at PageSyndicator Created: 19/Aug/13  Updated: 27/Aug/13  Resolved: 27/Aug/13

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0.12, 2.5.3

Type: Bug Priority: Neutral
Reporter: Milan Divilek Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLSTK-1230 Channel link must be a full and valid... Closed
dependency
depends upon MAGNOLIA-5246 PropertyUtil.getString should not thr... Closed
relation
is related to MGNLRSSAGG-76 Prevent NPEs at RSSModuleFeedGenerato... Closed
is related to MGNLCAT-89 Prevent NPEs at CategorySyndicator Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

When load feed from siteRoot which isn't exist then npe is thrown.

DEBUG  info.magnolia.jcr.util.SessionUtil 16.08.2013 20:28:22 -- There's no item with path: '/home/our-company/news/newsletter' in workspace: 'website'
ERROR  info.magnolia.module.rssaggregator.generator.AbstractSyndFeedGenerator 16.08.2013 20:28:22 -- Failed to generate Feed using generator 'info.magnolia.module.templatingkit.syndication.PageSyndicator'
java.lang.NullPointerException
	at info.magnolia.module.templatingkit.templates.category.TemplateCategoryUtil.getContentListByTemplateNames(TemplateCategoryUtil.java:227)
	at info.magnolia.module.templatingkit.templates.category.TemplateCategoryUtil.getContentListByTemplateCategorySubCategory(TemplateCategoryUtil.java:196)
	at info.magnolia.module.templatingkit.functions.STKTemplatingFunctions.getContentListByTemplateCategorySubCategory(STKTemplatingFunctions.java:394)
	at info.magnolia.module.templatingkit.functions.STKTemplatingFunctions.getContentListByTemplateCategorySubCategory(STKTemplatingFunctions.java:387)
	at info.magnolia.module.templatingkit.syndication.PageSyndicator.loadFeedEntries(PageSyndicator.java:101)
DEBUG  info.magnolia.jcr.util.SessionUtil 16.08.2013 21:29:31 -- There's no item with path: '/home/our-company/news/newsletter' in workspace: 'website'
ERROR  info.magnolia.module.rssaggregator.generator.AbstractSyndFeedGenerator 16.08.2013 21:29:31 -- Failed to generate Feed using generator 'info.magnolia.module.templatingkit.syndication.PageSyndicator'
java.lang.NullPointerException
	at info.magnolia.jcr.util.PropertyUtil.getString(PropertyUtil.java:346)
	at info.magnolia.jcr.util.PropertyUtil.getString(PropertyUtil.java:336)
	at info.magnolia.module.templatingkit.syndication.PageSyndicator.setFeedInfo(PageSyndicator.java:123)


 Comments   
Comment by Milan Divilek [ 21/Aug/13 ]

Reopen: Same reason as in MGNLCAT-89 (see http://jira.magnolia-cms.com/browse/MGNLCAT-89?focusedCommentId=68726&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-68726)

Comment by Jaroslav Simak [ 27/Aug/13 ]

Error on page if page does not exist:

com.sun.syndication.io.FeedException: Invalid rss_2.0 feed, missing channel link
	com.sun.syndication.io.impl.RSS090Generator.checkNotNullAndLength(RSS090Generator.java:128)
	com.sun.syndication.io.impl.RSS092Generator.checkChannelConstraints(RSS092Generator.java:139)
	com.sun.syndication.io.impl.RSS090Generator.addChannel(RSS090Generator.java:97)
	com.sun.syndication.io.impl.RSS091UserlandGenerator.addChannel(RSS091UserlandGenerator.java:77)
	com.sun.syndication.io.impl.RSS091UserlandGenerator.populateFeed(RSS091UserlandGenerator.java:73)
	com.sun.syndication.io.impl.RSS090Generator.generate(RSS090Generator.java:56)
	com.sun.syndication.io.WireFeedOutput.outputJDom(WireFeedOutput.java:271)
	com.sun.syndication.io.WireFeedOutput.outputString(WireFeedOutput.java:118)
	com.sun.syndication.io.WireFeedOutput.outputString(WireFeedOutput.java:97)
	com.sun.syndication.io.SyndFeedOutput.outputString(SyndFeedOutput.java:61)
Comment by Milan Divilek [ 27/Aug/13 ]

It was already released with 2.5.3. Created new ticket MGNLSTK-1230

Generated at Mon Feb 12 07:34:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.