[MGNLSTK-1234] Theme pop images are present twice after migration from 4.4.x Created: 29/Aug/13 Updated: 01/Oct/13 Resolved: 01/Oct/13 |
|
| Status: | Closed |
| Project: | Magnolia Standard Templating Kit (closed) |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 2.0.13 |
| Type: | Bug | Priority: | Major |
| Reporter: | Milan Divilek | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Date of First Response: |
| Description |
|
At Magnolia 4.4.x theme pop images was located in dms, but Magnolia 4.5.x has located those images in resources. Because we don't remove images from old location then after migration from 4.4.x we have those images presented at two locations: dms:/templating-kit/themes/pop/img Demo-project or Theme-pop module should remove images from dms. |
| Comments |
| Comment by Jan Haderka [ 13/Sep/13 ] |
|
I don't see any commits on the git tab nor in http://git.magnolia-cms.com/gitweb/?p=modules/standard-templating-kit.git;a=shortlog;h=refs/heads/standard-templating-kit-2.0.x Where is it? |
| Comment by Jan Haderka [ 16/Sep/13 ] |
|
RemovePopSourcesTask should be called RemoveDuplicatedPopThemeMediaFilesTask 84 try {
85 properties.load(this.getClass().getResourceAsStream("44uuidthemesrclist.properties"));
86 } catch (IOException e) {
87 log.warn("Can't load pop theme items list.");
88 return;
89 }
if you can't load your properties, you need to print user warning about removing duplicated resources themselves Any reason for having website.properties under /src/test/resources when it's empty? |
| Comment by Luboš Tkadlčík [ 17/Sep/13 ] |
|
Fix version just 2.0.13: duplicated pop theme media files removed during migration 4.4. -> 4.5, already not presented in 5.0. |
| Comment by Roman Kovařík [ 01/Oct/13 ] |
|
Images aren't bootstrapped but created so the uuids are different. And since someone can use these images from the same dms location, it is not safe to delete them w/o any warning. |