[MGNLSTK-1403] Download list does not work properly Created: 14/Jul/14  Updated: 16/Apr/15  Resolved: 21/Nov/14

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: None
Affects Version/s: 2.8
Fix Version/s: 2.8.6

Type: Bug Priority: Neutral
Reporter: Andreas Doebeli Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MGNLDAM-520 JcrAssetProvider#getQueryString must ... Closed
duplicate
duplicates MGNLSTK-1465 component "Download list" does not wo... Closed
is duplicated by MGNLSTK-1406 DownloadList issue Closed
relation
is related to MGNLSTK-1436 i18:n i18n-ize dialogs with hardcoded... Closed
is related to MGNLSTK-1434 DownloadLink throws TemplateModelExce... Closed
is related to MGNLSTK-1442 Adapt downloadList.ftl in order to di... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

The download list component lists all in the dam available documents. Furthermore, the path selection dialog shows an error after selecting a node that is not an asset.

Steps to reproduce:

  1. in the demo site, go to pate demo-project/service/imprint
  2. add a new content component in the content area and select "Download List"
  3. try to select a folder node in the selection dialog and click "choose". This should show an error (Action execution failed for action: commit)
  4. after that, the dialog won't let you change the selection
  5. refresh the page and repeat step 2
  6. try to select a document node and save. Now there is a list of (presumably) all available documents in the DAM instead of just the selected

I'm using:
Magnolia 5.3 (with Maven dependency management)
DAM 2.0
STK 2.8

Browser: Firefox 30.0 (not tested on others, but it seems to be a backend problem)



 Comments   
Comment by Andreas Doebeli [ 01/Sep/14 ]

Are there any news on this issue or plans to resolve it? This behavior is still reproducable on the demo.

Comment by Zdenek Skodik [ 09/Oct/14 ]

Andreas, the first part of folder selection has been fixed by MGNLDAM-480, the second part is scheduled for STK 2.8.5/Magnolia 5.3.5 (the bug comes from DownloadListModel you could eventually override in the meanwhile).

Comment by Christoph Meier [ 10/Oct/14 ]

What should be done if the user selects a folder?
a) disallow folder selection
b) list all the children of the selected folder (all descendants)
c) list only the direct children of the selected folder (not all sub-... sub-children)

Magnolia 4.5 does it like (c). => I will implement (c).

Comment by Christoph Meier [ 14/Oct/14 ]

Added a new field (checkbox) which allows to list all children (and sub-children) of a folder or the direct descendants only. =>
[ ] Show only direct children of the selected folder. (Default value is false.)

Bootstrap and ModuleVersionHandler has been adapted.
Now waiting for MGNLDAM-520.

Comment by Christoph Meier [ 27/Oct/14 ]

Merged master into the feature branch 'MGNLSTK-1403' (since master got a couple of changes meanwhile).

Comment by Christoph Meier [ 27/Oct/14 ]

To ease integration and keep git history short, i've created a new branch from master and added the changes to this new branch.
To review and integrate use branch 'MGNLSTK-1403_v2'.
(Do not consider branch 'MGNLSTK-1403')

Comment by Federico Grilli [ 18/Nov/14 ]

As found by a user on the forum https://forum.magnolia-cms.com/forum/thread.html?threadId=ca1ef931-ae0c-47ee-9482-cd97a41ea80c the feature basically didn't make into master (due to some mishap during integration) and thus was not released.

Comment by Mikaël Geljić [ 19/Nov/14 ]

i18nBasename property was added in bootstrap, but nothing was done in MVH in this regard. This will trigger a migration diff.

Generated at Mon Feb 12 07:36:14 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.