[MGNLSTK-1405] Change default behavior of ThemeVersionHandler: do not strip extensions when installing resources Created: 18/Jul/14  Updated: 15/Jan/16  Resolved: 05/Jan/16

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: themepop, update
Affects Version/s: 2.9.2
Fix Version/s: 2.9.3

Type: Bug Priority: Critical
Reporter: Rainer Blumenthal Assignee: Oanh Thai Hoang
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 25m
Time Spent: 1d 7h 35m
Original Estimate: 2d

Issue Links:
Relates
relates to MGNLSTK-494 Files from theme can differ in the fi... Closed
relates to MGNLSTK-1519 Do not strip resources extension in I... Closed
dependency
depends upon MGNLRES-181 STK theme resources appear twice afte... Closed
Template:
Acceptance criteria:
Empty
Release notes required:
Yes
Date of First Response:
Sprint: Saigon 26
Story Points: 3

 Description   

MGNLSTK-494 added the possibility to have the ThemeVersionHandler install 2 images in your theme "icon.jpg" + "icon.gif" with the same name but different file extension (see info.magnolia.module.resources.setup.InstallTextResourcesTask).

Due to backwards compatibility, this new feature was not made default but should rather be done in a next major version.

Update: MGNLRES-181 provides the resource upgrade task, re-adding extensions to node names. This task should be used here in a delta, most likely in STK VH.
See expected outcome (theme-pop) in concept for details.



 Comments   
Comment by Mikaël Geljić [ 29/Dec/15 ]

This is becoming critical on the 2.9 branch (5.4).

MGNLRES-181 consists of a task re-adding file extensions to node-names, for pre-existing resources, so that they do not show as duplicates in the resources app, alongside resources from classpath + file-system. This is pointless if we keep stripping the extension for fresh installs. Default has to change now.

Worth re-iterating that as of Magnolia 5.4, except for processed resources, it's no longer required to install resources into JCR at all; they may be served from classpath directly, if accessed via /.resources. But let's not change that yet.

Generated at Mon Feb 12 07:36:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.