[MGNLSTK-1445] Clean up STK Created: 10/Nov/14  Updated: 14/Jul/15  Resolved: 18/Dec/14

Status: Closed
Project: Magnolia Standard Templating Kit (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 2.9

Type: Task Priority: Neutral
Reporter: Federico Grilli Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLCAT-144 Remove usage of AutoGeneratedExtrasArea Closed
is causing MGNLWCS-110 Remove usage of AutoGeneratedExtrasArea Closed
is causing MSHOP-198 Remove usage of AutoGeneratedExtrasArea Closed
relation
is related to MGNLCAT-142 Remove deprecated AutoGeneratedExtras... Closed
is related to CNTCTSAPP-91 Cleanup install and update tasks Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: Extract STK functionality

 Description   

Remove (and replace when necessary) usages of long deprecated classes and methods.



 Comments   
Comment by Espen Jervidalo [ 12/Nov/14 ]

separate commits for version update from 2.8.5 -> 2.9 from the refactorings

update task for no-intro removal from demo-features homepage

update task for removed class

  • magnolia-module-standard-templating-kit/mgnl-bootstrap/standard-templating-kit/templates/pages/config.modules.standard-templating-kit.templates.pages.stkEventsOverview.xml

Update Tasks for bootstrap files removed:

  • magnolia-module-standard-templating-kit/mgnl-bootstrap/standard-templating-kit/templates/pages/demo-features/config.modules.standard-templating-kit.templates.pages.demo-features.stkSectionNoIntroWithHeader.xml
  • magnolia-module-standard-templating-kit/mgnl-bootstrap/standard-templating-kit/trees/*.xml

info.magnolia.module.templatingkit.search.SearchResultModel

  • missing @Deprecated in multiple places
  • log.error("", e); either add a sentence for clarification or drop the “”
  • use {} instead of string.format? #doQuery log.error(String.format(“... and offset %s", ..., offset));

missing @Deprecated (only presence in comments)

  • info.magnolia.module.templatingkit.search.SearchResultItem#processNodeDatas
  • info.magnolia.module.templatingkit.search.SearchResultItem#highlightSnippet

info.magnolia.module.templatingkit.setup.STKModuleVersionHandler

  • tasks.add(new AddContactUserRoleTask()); - why?

info.magnolia.module.templatingkit.syndication.PageSyndicator.FeedEntryMapper#map

  • remove commented code

info.magnolia.module.templatingkit.templates.components.EventsOverviewModel

  • inject I18nContentSupport in constructor, deprecate old?

info.magnolia.module.templatingkit.functions.STKTemplatingFunctionForAssetTest
– tests removed without replacement? those were introduced with Magnolia 5

Javadoc fixes:

javadoc, will probably fail with check style (missing 'BlaClass.' at least)?

  • info.magnolia.module.templatingkit.imaging.STKImagingSupportTest
  • info.magnolia.module.templatingkit.search.SearchResultItemTest
  • info.magnolia.module.templatingkit.imaging.CssSelectorRuleTest
  • info.magnolia.module.templatingkit.templates.STKTemplateAvailabilityTest

remove @author and/or @version

  • info.magnolia.module.templatingkit.templates.components.AbstractDateContentModelTest
  • info.magnolia.module.templatingkit.templates.components.CalendarModelTest
  • info.magnolia.module.templatingkit.setup.ThemeVersionHandler
  • info.magnolia.module.templatingkit.setup.MoveMenuItemTask
Generated at Mon Feb 12 07:36:38 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.